-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config]Fix missing config MptrieLogPath #3769
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3769 +/- ##
==========================================
+ Coverage 74.47% 75.08% +0.61%
==========================================
Files 269 299 +30
Lines 23925 25202 +1277
==========================================
+ Hits 17818 18923 +1105
- Misses 5174 5299 +125
- Partials 933 980 +47
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
config/config.go
Outdated
@@ -129,6 +129,7 @@ type ( | |||
Log log.GlobalConfig `yaml:"log"` | |||
SubLogs map[string]log.GlobalConfig `yaml:"subLogs"` | |||
Genesis genesis.Genesis `yaml:"genesis"` | |||
MptrieLogPath string `yaml:"mptrieLogPath"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System
at L103 above is a more proper place for this config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, has been moved into System
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
missing in commit d485731
Fixes #3634
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: