Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config]Fix missing config MptrieLogPath #3769

Merged
merged 3 commits into from
Jan 17, 2023
Merged

[config]Fix missing config MptrieLogPath #3769

merged 3 commits into from
Jan 17, 2023

Conversation

millken
Copy link
Contributor

@millken millken commented Jan 16, 2023

Description

missing in commit d485731
Fixes #3634

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #3769 (bd80259) into master (263ff82) will increase coverage by 0.61%.
The diff coverage is 81.32%.

@@            Coverage Diff             @@
##           master    #3769      +/-   ##
==========================================
+ Coverage   74.47%   75.08%   +0.61%     
==========================================
  Files         269      299      +30     
  Lines       23925    25202    +1277     
==========================================
+ Hits        17818    18923    +1105     
- Misses       5174     5299     +125     
- Partials      933      980      +47     
Impacted Files Coverage Δ
action/actctx.go 90.62% <ø> (+6.25%) ⬆️
action/action.go 82.35% <ø> (ø)
action/action_deserializer.go 57.14% <ø> (ø)
action/candidate_update.go 88.88% <0.00%> (-4.14%) ⬇️
action/consignment_transfer.go 90.41% <ø> (ø)
action/const.go 100.00% <ø> (ø)
action/execution.go 83.78% <ø> (ø)
action/grantreward.go 68.57% <ø> (ø)
action/protocol/account/protocol.go 86.90% <ø> (ø)
action/protocol/account/transfer.go 84.61% <ø> (ø)
... and 276 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

config/config.go Outdated
@@ -129,6 +129,7 @@ type (
Log log.GlobalConfig `yaml:"log"`
SubLogs map[string]log.GlobalConfig `yaml:"subLogs"`
Genesis genesis.Genesis `yaml:"genesis"`
MptrieLogPath string `yaml:"mptrieLogPath"`
Copy link
Member

@dustinxie dustinxie Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System at L103 above is a more proper place for this config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, has been moved into System

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@millken millken changed the title fix missing config MptrieLogPath [config]Fix missing config MptrieLogPath Jan 17, 2023
@dustinxie dustinxie merged commit 9f25b0b into iotexproject:master Jan 17, 2023
@millken millken deleted the fixmptrieconfig branch January 17, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants