update docker build command #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
raullenchai
approved these changes
Jan 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #3751 +/- ##
==========================================
+ Coverage 74.47% 75.12% +0.65%
==========================================
Files 269 297 +28
Lines 23925 24957 +1032
==========================================
+ Hits 17818 18749 +931
- Misses 5174 5236 +62
- Partials 933 972 +39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dustinxie
approved these changes
Jan 5, 2023
envestcc
added a commit
that referenced
this pull request
Jan 12, 2023
* move IsValidCandidateName to action package (#3706) * move IsValidCandidateName to action package * move IsValidCandidateName to action package * delete validations.go * update tests * delete ErrInvalidAmount in staking * Remove stale comment "This is an alpha release and is not ...." in all files (#3713) * remove stale comment * remove stale comment * remove nonce field (#3714) Co-authored-by: dustinxie <[email protected]> * [evm] proper handle refundSnapshot and upgrade go-ethereum release (#3715) * [ioctl] modify did command parameters (#3668) * modify action.Read default parameters * use constant * use config.GasStation instead of config.API #3718 (#3721) Co-authored-by: dustinxie <[email protected]> * [genesis] set Okhotsk to activate at 01-11-2023 12am UTC (#3720) * [tests] add more cases for gas refund (#3707) * add more cases for gas refund * remove debug flag Co-authored-by: dustinxie <[email protected]> * [api] web3 rewarding action (#3691) * add rewarding execute action * add rewarding execute test * add commmet for public type * add builder test * complete web3 rewarding read * complete web3 rewarding read test * remove read api and receive create rewarding action enterance * add test to rlp tx test * change name * revert fix amount bug for deposit cost bug * change check error style * add entrance for web3 rewarding Co-authored-by: dustinxie <[email protected]> * update mockgen (#3733) * [ioctl] use candidate.OperatorAddress to show probated delegates (#3727) Co-authored-by: dustinxie <[email protected]> * [config] move config.Consensus to consensus package (#3735) * [action] validate candidate name (#3705) * Update release.yaml * [config] move config.Blocksync to blocksync package (#3736) * move config.BlockSync to blocksync package * remove def of BlockSync in config * rename newBlockSyncer to newBlockSyncerForTest * [ioctl] Build contract deploy command line into new ioctl (#3708) * [ioctl] build contract deploy command line into new ioctl * build unittest to cover the modification1~ * group iotex-core packages * remove stale comments Co-authored-by: huofei <[email protected]> * [ioctl] Build contract invoke command line into new ioctl (#3709) * [ioctl] build contract invoke command line into new ioctl * build unittest to cover the modification1~ * remove stale comments Co-authored-by: huofei <[email protected]> * [github] Update codeowner (#3742) * [ioctl] Build contract compile command line into new ioctl (#3676) * [ioctl] build contract compile command line into new ioctl Co-authored-by: huof6890 <[email protected]> * [config] move config.API to api package (#3739) * move config.GasStation to gasstation package * move config.API to api package * make fields of testConfig to be private Co-authored-by: CoderZhi <[email protected]> * complete web3 intergrity test (#3743) * complete tests * complete requires * format * init monitor message framework * [ioctl/newcmd] fix node delegate run failed (#3729) * fix grpc error and show right datas * check chainMeta.Epoch * modify as currEpochNum * init broadcast framework * update broadcast framework * update broadcast framework * [ioctl] Build contract test bytecode command line into new ioctl (#3738) * [ioctl] build contract test bytecode command line into new ioctl * build unittest to cover the modification * format Co-authored-by: huofei <[email protected]> * [ioctl] Build contract prepare command line into new ioctl (#3737) * [ioctl] build contract prepare command line into new ioctl * build unittest to cover the modification * fix commit * update assert message * update solc version * update solc message version * format * brew install solidity Co-authored-by: huofei <[email protected]> * add node package to handle node info manager * update * Update release.yaml * Revert "adding .dockerignore file to fix git submodule builds (#3689)" (#3750) This reverts commit c14dcca. Co-authored-by: Jeremi [IoTeX] Rynkiewicz JRPC <[email protected]> * update docker build command (#3751) * [actpool] Improve actqueue efficiency (#3377) * opt actpool.Add() * improve actqueue efficiency * add node info request and response message * remove delegate manager dependency * add message sign * add sign for node info message * fix unittest error * Update CODEOWNERS (#3754) * [rewarding] add active web3 rewarding settings (#3740) * add active web3 rewarding settings * check active when encoding is web3 * check active with deposit action * remove check logic to workingset * add check in API module * fix check validte web3 rewarding bug Co-authored-by: Haaai <[email protected]> * add unittest for node * add pubkey in nodeinfo message * fix compile error * update go.mod Co-authored-by: millken <[email protected]> Co-authored-by: huofei <[email protected]> Co-authored-by: dustinxie <[email protected]> Co-authored-by: Xueping Yang <[email protected]> Co-authored-by: xianhuawei <[email protected]> Co-authored-by: Jeremy Chou <[email protected]> Co-authored-by: Haaai <[email protected]> Co-authored-by: CoderZhi <[email protected]> Co-authored-by: Jeremi [IoTeX] Rynkiewicz JRPC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A long term solution to solve getting version info failed when building docker image on DockerHub:
PACKAGE_VERSION,PACKAGE_COMMIT_ID,GIT_STATUSare supported by env variable in MakefilePACKAGE_VERSION,PACKAGE_COMMIT_ID,GIT_STATUSthree args in DockerfileFixes #3746
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: