-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg] rotate log file #3638
[pkg] rotate log file #3638
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3638 +/- ##
==========================================
- Coverage 74.95% 74.62% -0.33%
==========================================
Files 269 264 -5
Lines 23819 23687 -132
==========================================
- Hits 17854 17677 -177
- Misses 5039 5083 +44
- Partials 926 927 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
After reach |
pls fix the log rotate issue with logrotate |
It's a linux tool. cannot use in win/mac |
pkg/log/log.go
Outdated
RedirectStdLog bool `json:"stdLogRedirect" yaml:"stdLogRedirect"` | ||
EcsIntegration bool `json:"ecsIntegration" yaml:"ecsIntegration"` | ||
Zap *zap.Config `json:"zap" yaml:"zap"` | ||
Lumberjack *lumberjack.Logger `json:"lumberjack" yaml:"lumberjack"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to end
config/standalone-config.yaml
Outdated
stdLogRedirect: true | ||
lumberjack: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this included in Alpine image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or test if logrotate can work or not
|
@xianhuawei @huof6829 could you try this PR in k8s? |
ok, we will run in testnet |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #2661
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: