Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Clean up config #3492

Merged
merged 3 commits into from
Jul 5, 2022
Merged

[config] Clean up config #3492

merged 3 commits into from
Jul 5, 2022

Conversation

Liuhaai
Copy link
Member

@Liuhaai Liuhaai commented Jul 1, 2022

Description

  • config.Default.Genesis is changed to genesis.Default
  • p2p.Network is changed to p2p.Config

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@Liuhaai Liuhaai requested a review from a team as a code owner July 1, 2022 20:19
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #3492 (e1299ce) into master (91fd545) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3492   +/-   ##
=======================================
  Coverage   75.40%   75.40%           
=======================================
  Files         245      245           
  Lines       22699    22699           
=======================================
  Hits        17117    17117           
  Misses       4656     4656           
  Partials      926      926           
Impacted Files Coverage Δ
config/config.go 85.29% <ø> (ø)
blockchain/filedao/testing.go 59.71% <100.00%> (ø)
p2p/agent.go 77.85% <100.00%> (ø)
server/itx/heartbeat.go 78.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91fd545...e1299ce. Read the comment docs.

@Liuhaai Liuhaai merged commit 4e397d3 into iotexproject:master Jul 5, 2022
Liuhaai added a commit that referenced this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants