Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] impletment TestGrpcServer_GetAccount by gomock CoreService inte… #3488

Merged

Conversation

LuckyPigeon
Copy link
Contributor

@LuckyPigeon LuckyPigeon commented Jun 29, 2022

Description

Impletment TestGrpcServer_GetAccount in ./api/grpcserver_test.go by gomock CoreService interface

Fixes #3220

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • TestGrpcServer_GetAccount

Test Configuration:

  • Firmware version: Ubuntu 21.04
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #3488 (9bae557) into master (a48569e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3488      +/-   ##
==========================================
- Coverage   75.35%   75.34%   -0.01%     
==========================================
  Files         246      246              
  Lines       22754    22754              
==========================================
- Hits        17146    17144       -2     
- Misses       4683     4685       +2     
  Partials      925      925              
Impacted Files Coverage Δ
db/trie/mptrie/branchnode.go 97.22% <0.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48569e...9bae557. Read the comment docs.

@LuckyPigeon LuckyPigeon marked this pull request as ready for review June 29, 2022 18:15
@LuckyPigeon LuckyPigeon requested a review from a team as a code owner June 29, 2022 18:15
@Liuhaai Liuhaai merged commit 9347fed into iotexproject:master Jul 6, 2022
@LuckyPigeon LuckyPigeon deleted the dev_test_grpc_server_get_account branch August 5, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[api] impletment TestGrpcServer_GetAccount by gomock CoreService interface
3 participants