[action] use SenderAddress() to replace SrcPubkey().Address() (#3446)

Co-authored-by: Haaai <[email protected]>

action/protocol/generic_validator.go

@@ -49,7 +49,7 @@ func (v *GenericValidator) Validate(_ context.Context, selp action.SealedEnvelop
 	if err := selp.VerifySignature(); err != nil {
 		return err
 	}
-	caller := selp.SrcPubkey().Address()
+	caller := selp.SenderAddress()
 	if caller == nil {
 		return errors.New("failed to get address")
 	}

action/protocol/poll/governance_protocol_test.go

@@ -395,7 +395,7 @@ func TestHandle(t *testing.T) {
 		selp2, err := action.Sign(elp, senderKey)
 		require.NoError(err)
 		require.NotNil(selp2)
-		caller := selp2.SrcPubkey().Address()
+		caller := selp2.SenderAddress()
 		require.NotNil(caller)
 		ctx2 = protocol.WithBlockCtx(
 			ctx2,
@@ -442,7 +442,7 @@ func TestHandle(t *testing.T) {
 		selp2, err := action.Sign(elp, senderKey)
 		require.NoError(err)
 		require.NotNil(selp2)
-		caller := selp2.SrcPubkey().Address()
+		caller := selp2.SenderAddress()
 		require.NotNil(caller)
 		ctx2 = protocol.WithBlockCtx(
 			ctx2,
@@ -477,7 +477,7 @@ func TestHandle(t *testing.T) {
 		selp3, err := action.Sign(elp, senderKey)
 		require.NoError(err)
 		require.NotNil(selp3)
-		caller := selp3.SrcPubkey().Address()
+		caller := selp3.SenderAddress()
 		require.NotNil(caller)
 		ctx3 = protocol.WithBlockCtx(
 			ctx3,
@@ -511,7 +511,7 @@ func TestHandle(t *testing.T) {
 		selp4, err := action.Sign(elp4, senderKey)
 		require.NoError(err)
 		require.NotNil(selp4)
-		caller := selp4.SrcPubkey().Address()
+		caller := selp4.SenderAddress()
 		require.NotNil(caller)
 		ctx4 = protocol.WithBlockCtx(
 			ctx4,
@@ -545,7 +545,7 @@ func TestHandle(t *testing.T) {
 		selp5, err := action.Sign(elp5, senderKey)
 		require.NoError(err)
 		require.NotNil(selp5)
-		caller := selp5.SrcPubkey().Address()
+		caller := selp5.SenderAddress()
 		require.NotNil(caller)
 		ctx5 = protocol.WithBlockCtx(
 			ctx5,

action/protocol/poll/staking_committee_test.go

@@ -261,7 +261,7 @@ func TestHandle_StakingCommittee(t *testing.T) {
 		selp2, err := action.Sign(elp, senderKey)
 		require.NoError(err)
 		require.NotNil(selp2)
-		caller := selp2.SrcPubkey().Address()
+		caller := selp2.SenderAddress()
 		require.NotNil(caller)
 		ctx2 = protocol.WithBlockCtx(
 			ctx2,
@@ -298,7 +298,7 @@ func TestHandle_StakingCommittee(t *testing.T) {
 		selp3, err := action.Sign(elp, senderKey)
 		require.NoError(err)
 		require.NotNil(selp3)
-		caller := selp3.SrcPubkey().Address()
+		caller := selp3.SenderAddress()
 		require.NotNil(caller)
 		ctx3 = protocol.WithBlockCtx(
 			ctx3,
@@ -334,7 +334,7 @@ func TestHandle_StakingCommittee(t *testing.T) {
 		selp4, err := action.Sign(elp4, senderKey)
 		require.NoError(err)
 		require.NotNil(selp4)
-		caller := selp4.SrcPubkey().Address()
+		caller := selp4.SenderAddress()
 		require.NotNil(caller)
 		ctx4 = protocol.WithBlockCtx(
 			ctx4,
@@ -370,7 +370,7 @@ func TestHandle_StakingCommittee(t *testing.T) {
 		selp5, err := action.Sign(elp5, senderKey)
 		require.NoError(err)
 		require.NotNil(selp5)
-		caller := selp5.SrcPubkey().Address()
+		caller := selp5.SenderAddress()
 		require.NotNil(caller)
 		ctx5 = protocol.WithBlockCtx(
 			ctx5,

actpool/actpool.go

@@ -227,7 +227,7 @@ func (ap *actPool) Add(ctx context.Context, act action.SealedEnvelope) error {
 		return err
 	}
 
-	caller := act.SrcPubkey().Address()
+	caller := act.SenderAddress()
 	if caller == nil {
 		return action.ErrAddress
 	}
@@ -331,7 +331,7 @@ func (ap *actPool) validate(ctx context.Context, selp action.SealedEnvelope) err
 	span.AddEvent("actPool.validate")
 	defer span.End()
 
-	caller := selp.SrcPubkey().Address()
+	caller := selp.SenderAddress()
 	if caller == nil {
 		return errors.New("failed to get address")
 	}

api/coreservice.go

@@ -514,7 +514,7 @@ func (core *coreService) EstimateGasForAction(ctx context.Context, in *iotextype
 		}
 		return gas, nil
 	}
-	callerAddr := selp.SrcPubkey().Address()
+	callerAddr := selp.SenderAddress()
 	if callerAddr == nil {
 		return 0, status.Error(codes.Internal, "failed to get address")
 	}
@@ -1166,7 +1166,7 @@ func (core *coreService) committedAction(selp action.SealedEnvelope, blkHash has
 	if err != nil {
 		return nil, err
 	}
-	sender := selp.SrcPubkey().Address()
+	sender := selp.SenderAddress()
 	receipt, err := core.dao.GetReceiptByActionHash(actHash, blkHeight)
 	if err != nil {
 		return nil, err
@@ -1190,7 +1190,7 @@ func (core *coreService) pendingAction(selp action.SealedEnvelope) (*iotexapi.Ac
 	if err != nil {
 		return nil, err
 	}
-	sender := selp.SrcPubkey().Address()
+	sender := selp.SenderAddress()
 	return &iotexapi.ActionInfo{
 		Action:    selp.Proto(),
 		ActHash:   hex.EncodeToString(actHash[:]),
@@ -1242,7 +1242,7 @@ func (core *coreService) reverseActionsInBlock(blk *block.Block, reverseStart, c
 			continue
 		}
 		gas := new(big.Int).Mul(selp.GasPrice(), big.NewInt(int64(receipt.GasConsumed)))
-		sender := selp.SrcPubkey().Address()
+		sender := selp.SenderAddress()
 		res = append([]*iotexapi.ActionInfo{{
 			Action:    selp.Proto(),
 			ActHash:   hex.EncodeToString(actHash[:]),

api/grpcserver.go

@@ -227,7 +227,7 @@ func actionsInBlock(blk *block.Block, receipts []*action.Receipt, start, count u
 			continue
 		}
 		gas := new(big.Int).Mul(selp.GasPrice(), big.NewInt(int64(receipt.GasConsumed)))
-		sender := selp.SrcPubkey().Address()
+		sender := selp.SenderAddress()
 		res = append(res, &iotexapi.ActionInfo{
 			Action:    selp.Proto(),
 			ActHash:   hex.EncodeToString(actHash[:]),
@@ -647,7 +647,7 @@ func (svr *GRPCServer) TraceTransactionStructLogs(ctx context.Context, in *iotex
 		NoBaseFee: true,
 	})
 
-	_, _, err = svr.coreService.SimulateExecution(ctx, act.SrcPubkey().Address(), sc)
+	_, _, err = svr.coreService.SimulateExecution(ctx, act.SenderAddress(), sc)
 	if err != nil {
 		return nil, err
 	}

api/web3server.go

@@ -552,7 +552,7 @@ func (svr *web3Handler) getTransactionReceipt(in *gjson.Result) (interface{}, er
 
 	return &getReceiptResult{
 		blockHash:       blockHash,
-		from:            selp.SrcPubkey().Address(),
+		from:            selp.SenderAddress(),
 		to:              to,
 		contractAddress: contractAddr,
 		logsBloom:       blkMeta.LogsBloom,

state/factory/workingset.go

@@ -124,7 +124,7 @@ func (ws *workingSet) runActions(
 func withActionCtx(ctx context.Context, selp action.SealedEnvelope) (context.Context, error) {
 	var actionCtx protocol.ActionCtx
 	var err error
-	caller := selp.SrcPubkey().Address()
+	caller := selp.SenderAddress()
 	if caller == nil {
 		return nil, errors.New("failed to get address")
 	}
@@ -326,7 +326,7 @@ func (ws *workingSet) CreateGenesisStates(ctx context.Context) error {
 func (ws *workingSet) validateNonce(blk *block.Block) error {
 	accountNonceMap := make(map[string][]uint64)
 	for _, selp := range blk.Actions {
-		caller := selp.SrcPubkey().Address()
+		caller := selp.SenderAddress()
 		if caller == nil {
 			return errors.New("failed to get address")
 		}
@@ -445,7 +445,7 @@ func (ws *workingSet) pickAndRunActions(
 				}
 			}
 			if err != nil {
-				caller := nextAction.SrcPubkey().Address()
+				caller := nextAction.SenderAddress()
 				if caller == nil {
 					return nil, errors.New("failed to get address")
 				}