Misc EVM fixes #2884
Merged
Misc EVM fixes #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemmsilva
approved these changes
Sep 21, 2023
Comment on lines
+33
to
+35
| # use like: make build-tool TOOL=./tools/dbinspector | ||
| build-tool: | ||
| $(BUILD_CMD) $(TOOL) |
There was a problem hiding this comment.
suggestion:
Suggested change
| # use like: make build-tool TOOL=./tools/dbinspector | |
| build-tool: | |
| $(BUILD_CMD) $(TOOL) | |
| # use like: make build-tool TOOL=dbinspector | |
| build-tool: | |
| $(BUILD_CMD) ./tools/$(TOOL) |
There was a problem hiding this comment.
Idk, I like both options. I'll leave it as it is because the evmemulator is in tools/evm/evmemulator and it would be awkwardish to say TOOL=evm/evmemulator 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes the Uniswap test suite can be run against ISC.
evmemulatortoolevm_snapshotjsonrpc endpoint