This repository was archived by the owner on Jun 7, 2023. It is now read-only.
Update electron-builder to 21.2.0 #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling for mac fails on macOS 10.15.1 with the following error: "Can't locate Mac/Memory.pm" The error originates from electron-builder which is now fixed in their latest version. See: electron-userland/electron-builder#3990
rajivshah3
approved these changes
Dec 16, 2019
cvarley100
pushed a commit
that referenced
this pull request
Dec 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compiling for mac fails on macOS 10.15.1 with the following error:
"Can't locate Mac/Memory.pm"
The error originates from
electron-builderwhich is now fixed in their latest version.See: electron-userland/electron-builder#3990
Type of change
How Has This Been Tested?
npm run compile:macChecklist:
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodesshared: If applicable, I have verified that my changes are implemented correctly indesktopandmobile