Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable for gossip port #45

Merged
merged 22 commits into from
May 24, 2024
Merged

Conversation

TeeVeeEss
Copy link
Contributor

Port 15600 could already be in use for e.g. your mainnet node. With this new variable in .env it should be easy to switch to another port,

@JannemanDev
Copy link

Shouldn't this also contain the variable?

#EXTERNAL_P2P_MULTIADDRESS=/dns/${NODE_HOST}/tcp/15600

@TeeVeeEss
Copy link
Contributor Author

TeeVeeEss commented May 18, 2024

Shouldn't this also contain the variable?

#EXTERNAL_P2P_MULTIADDRESS=/dns/${NODE_HOST}/tcp/15600

No. The internal port 15600 stays the same. Only the external port changes to the desired one. But @muXxer will probably check this ;)

@TeeVeeEss
Copy link
Contributor Author

Added the port section on top to be able to use it later in the .env file.
Not sure if --p2p.autopeering.externalMultiAddresses=${EXTERNAL_P2P_MULTIADDRESS:-} can be used in all versions though.

@muXxer muXxer force-pushed the TeeVeeEss-gossip-port branch from 7697a1d to 2207c93 Compare May 24, 2024 14:54
@muXxer muXxer force-pushed the TeeVeeEss-gossip-port branch from 2207c93 to 53df1c0 Compare May 24, 2024 15:14
@muXxer
Copy link
Contributor

muXxer commented May 24, 2024

I cleaned it a bit up :trollface:
Thank you very much!

@muXxer muXxer merged commit 05a2084 into iotaledger:main May 24, 2024
@TeeVeeEss TeeVeeEss deleted the TeeVeeEss-gossip-port branch May 25, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants