Skip to content
This repository was archived by the owner on Aug 23, 2020. It is now read-only.

Set minimum values for LS #1248

Merged
merged 2 commits into from
Dec 22, 2018

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Dec 20, 2018

Description

Sets minimum values to pruning delay and depth for local snapshots

Fixes #1217

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Unit tests

@jakubcech
Copy link
Contributor

Just to add here, I changed the minimum value to 40,000, instead of the first proposed 30,000. It better represents 30 days of transactions, and also more suitable for back references.

@DyrellC
Copy link
Contributor

DyrellC commented Dec 20, 2018

@jakubcech So we don't want to have the option to store less than 30 days of transactions for LS nodes? I've had several nodes running on much less and the DB's have been very small as a result, and the nodes have had no problem operating longer term. Is this a minimum that may change in the future to accommodate the smaller devices that may not want to be storing a full 30 days?

@jakubcech
Copy link
Contributor

I expect the value to change, possibly so in the not too far off future.

@GalRogozinski GalRogozinski merged commit 4fe2d7d into iotaledger:dev-localsnapshots Dec 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants