This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Perf: Massively improved the performance of the replayMilestones method #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 26, 2018 16:41
src/main/java/com/iota/iri/service/snapshot/impl/SnapshotImpl.java
Outdated
Show resolved
Hide resolved
| Objects.equals(metaData, ((SnapshotImpl) obj).metaData) && | ||
| Objects.equals(skippedMilestones, ((SnapshotImpl) obj).skippedMilestones); | ||
| } | ||
|
|
There was a problem hiding this comment.
It will also be nice to have a toString() here.
The toString() may only print SnapshotMetadata` toString() to not make it a reasonable size (index, hash, hasSolidEntryPoints). You can also decide to have it print the state, but it will be long.
Whatever you think will help with debugging
There was a problem hiding this comment.
We can add that in another PR - maybe create an issue to check if all models have these toString methods.
src/main/java/com/iota/iri/service/snapshot/impl/SnapshotServiceImpl.java
Show resolved
Hide resolved
src/main/java/com/iota/iri/service/snapshot/impl/SnapshotServiceImpl.java
Show resolved
Hide resolved
alon-e
approved these changes
Nov 28, 2018
src/main/java/com/iota/iri/service/snapshot/impl/SnapshotServiceImpl.java
Outdated
Show resolved
Hide resolved
| @@ -112,6 +113,10 @@ public void applyStateDiff(SnapshotStateDiff diff) throws SnapshotException { | |||
| if (balances.computeIfPresent(addressHash, (hash, aLong) -> balance + aLong) == null) { | |||
| balances.putIfAbsent(addressHash, balance); | |||
| } | |||
|
|
|||
| if (balances.get(addressHash) == 0) { | |||
added 7 commits
November 29, 2018 00:42
…t/iri into merge_replaymilestonesrefactor
GalRogozinski
approved these changes
Nov 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the replayMilestones method to first accumulate all changes and then apply them in a single call. This allows us to modify the milestone without having to create a copy of the state first. Since the Snapshot and its corresponding SnapshotState are huge datastructures, this change reduces the time required for a rebuild of the ledger state after a IRI restart from a few hours to a few seconds (for a non-snapshotted database).
Type of change
Checklist: