Skip to content
This repository was archived by the owner on Aug 23, 2020. It is now read-only.

Fix remove source port check #1156

Merged
merged 7 commits into from
Nov 19, 2018
Merged

Fix remove source port check #1156

merged 7 commits into from
Nov 19, 2018

Conversation

georgmittendorfer
Copy link
Contributor

@georgmittendorfer georgmittendorfer commented Nov 17, 2018

Description

Removed source port check for receiving data from neighbors (TCP and UDP). That allows to receive data from neighbors that use other source ports than target ports.

Hopefully fixes #961 UDP Peering Source Port Problem.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Feature is unit tested.
  • Feature for UDP is manually end to end tested.
  • Feature for TCP is not end to end tested.

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Discussion:

  • Would be great if someone could end 2 end test this to verify that the fix works not only in my setup.
  • I am not sure, if the fix makes sense for TCP. TCP worked properly before in my setup. I can change the fix to UPD only if desired.
  • Adding/removing neighbors works as before. No changes there.

@iotaledger iotaledger deleted a comment Nov 17, 2018
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The request changes is mainly because of the version change

@iotaledger iotaledger deleted a comment Nov 18, 2018
@iotaledger iotaledger deleted a comment Nov 18, 2018
@iotaledger iotaledger deleted a comment Nov 18, 2018
@iotaledger iotaledger deleted a comment Nov 18, 2018
@iotaledger iotaledger deleted a comment Nov 18, 2018
@iotaledger iotaledger deleted a comment Nov 18, 2018
@iotaledger iotaledger deleted a comment from georgmittendorfer Nov 18, 2018
@iotaledger iotaledger deleted a comment Nov 18, 2018
@iotaledger iotaledger deleted a comment Nov 18, 2018
@iotaledger iotaledger deleted a comment from georgmittendorfer Nov 18, 2018
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@GalRogozinski GalRogozinski merged commit 9437798 into iotaledger:dev Nov 19, 2018
@jakubcech
Copy link
Contributor

🎉 🎉 🎉

@GalRogozinski GalRogozinski mentioned this pull request Dec 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UDP Peering Source Port Problem
3 participants