This repository was archived by the owner on Aug 23, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 370
Fix remove source port check #1156
Merged
GalRogozinski
merged 7 commits into
iotaledger:dev
from
georgmittendorfer:fix-remove-source-port-check
Nov 19, 2018
Merged
Fix remove source port check #1156
GalRogozinski
merged 7 commits into
iotaledger:dev
from
georgmittendorfer:fix-remove-source-port-check
Nov 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalRogozinski
suggested changes
Nov 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The request changes is mainly because of the version change
GalRogozinski
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
🎉 🎉 🎉 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed source port check for receiving data from neighbors (TCP and UDP). That allows to receive data from neighbors that use other source ports than target ports.
Hopefully fixes #961 UDP Peering Source Port Problem.
Type of change
How Has This Been Tested?
Checklist:
Discussion: