This repository was archived by the owner on Aug 23, 2020. It is now read-only.
MilestoneTracker and LedgerValidator rework #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into merge_milestonetracker_rework
src/main/java/com/iota/iri/service/ledger/impl/LedgerServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iota/iri/service/milestone/LatestMilestoneTracker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iota/iri/service/milestone/SeenMilestonesRetriever.java
Outdated
Show resolved
Hide resolved
| if (currentSolidMilestoneIndex < latestMilestoneTracker.getLatestMilestoneIndex()) { | ||
| MilestoneViewModel nextMilestone; | ||
| while (!Thread.currentThread().isInterrupted() && | ||
| (nextMilestone = MilestoneViewModel.get(tangle, currentSolidMilestoneIndex + 1)) != null && |
There was a problem hiding this comment.
I think that this should be bound by latestMilestoneTracker.getLatestMilestoneIndex() because you are doing an extra read from the db
Seems like a minor issue
There was a problem hiding this comment.
Since the latestMilestoneTracker currently scans all candidates at the start it can take a really long time to have the correct value - If we find another solid milestone here I think it should be processed without waiting for the latestMilestoneTracker to advance to this milestone (thats also the reason why we have the method that syncs with the latestMilestoneTracker further down in the code).
src/main/java/com/iota/iri/service/milestone/SeenMilestonesRetriever.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iota/iri/service/milestone/impl/LatestSolidMilestoneTrackerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iota/iri/service/milestone/impl/LatestSolidMilestoneTrackerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iota/iri/service/milestone/impl/LatestSolidMilestoneTrackerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iota/iri/service/milestone/impl/LatestSolidMilestoneTrackerImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prepare and simplify the next PR that enables the remaining features, we introduce a new milestone and ledger package that contains a rework of the named classes. They conform to the new code guidelines (using interfaces and fully documented).
Type of change
How Has This Been Tested?
Additional Unit Tests will be written later.
Checklist:
Please delete items that are not relevant.