This repository was archived by the owner on Aug 23, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubcech
reviewed
Nov 14, 2018
src/main/java/com/iota/iri/Iota.java
Outdated
* | ||
* <p> | ||
* During initialization, all the Providers can be set to rescan or revalidate its transactions. | ||
* After initialization, an asynchronous process has started which will process incoming and outbound transactions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* After initialization, an asynchronous process has started which will process incoming and outbound transactions. | |
* After initialization, an asynchronous process starts which will process incoming and outbound transactions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well.. Technically AFTER the init(), the process has already started. Its notlike there is code which does if (init()) { startProcess()}
:D But i guess this reads easier etc.
I'll make one more pass tomorrow, my brain can't process things anymore :) |
alon-e
reviewed
Nov 15, 2018
alon-e
approved these changes
Nov 18, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes documentation for the IRI and Iota classes
Fixes #1108
Type of change
Checklist: