Skip to content
This repository was archived by the owner on Aug 23, 2020. It is now read-only.

Docmented IRI and Iota #1150

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Docmented IRI and Iota #1150

merged 2 commits into from
Nov 19, 2018

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Nov 14, 2018

Description

Includes documentation for the IRI and Iota classes

Fixes #1108

Type of change

  • Documentation Fix

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kwek20 kwek20 requested a review from jakubcech November 14, 2018 16:31
*
* <p>
* During initialization, all the Providers can be set to rescan or revalidate its transactions.
* After initialization, an asynchronous process has started which will process incoming and outbound transactions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* After initialization, an asynchronous process has started which will process incoming and outbound transactions.
* After initialization, an asynchronous process starts which will process incoming and outbound transactions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well.. Technically AFTER the init(), the process has already started. Its notlike there is code which does if (init()) { startProcess()} :D But i guess this reads easier etc.

@jakubcech
Copy link
Contributor

I'll make one more pass tomorrow, my brain can't process things anymore :)

@iotaledger iotaledger deleted a comment Nov 16, 2018
@jakubcech jakubcech self-assigned this Nov 19, 2018
@jakubcech jakubcech merged commit 37982a4 into iotaledger:dev Nov 19, 2018
@GalRogozinski GalRogozinski mentioned this pull request Dec 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants