Transaction Validator Documentation #1142

GalRogozinski · 2018-11-12T13:48:00Z

Description

Document Transaction Validator

Fixes #1107

Type of change

Documentation Fix

src/main/java/com/iota/iri/TransactionValidator.java

jakubcech · 2018-11-12T14:23:11Z

src/main/java/com/iota/iri/TransactionValidator.java

+    /**
+     * Does two things
+     * <ol>
+     *     <li>Sets the minimum weight magnitude. We validate POW on a transaction we will ascertain that it has


Suggested change

* <li>Sets the minimum weight magnitude. We validate POW on a transaction we will ascertain that it has

* <li>Sets the minimum weight magnitude (MWM). When we validate POW on a transaction, we validate that it has

src/main/java/com/iota/iri/TransactionValidator.java

Co-Authored-By: GalRogozinski <[email protected]>

alon-e · 2018-11-12T15:04:59Z

src/main/java/com/iota/iri/TransactionValidator.java

@@ -29,14 +31,34 @@
    private static final long MAX_TIMESTAMP_FUTURE = 2L * 60L * 60L;
    private static final long MAX_TIMESTAMP_FUTURE_MS = MAX_TIMESTAMP_FUTURE * 1_000L;

+
+    //*****************fields for solidification thread*********************************//


I thought we agreed on (w/o enforcement) //////// :)

src/main/java/com/iota/iri/TransactionValidator.java

alon-e · 2018-11-12T15:12:21Z

src/main/java/com/iota/iri/TransactionValidator.java

    public void shutdown() throws InterruptedException {
        shuttingDown.set(true);
        newSolidThread.join();
    }

+    /**
+     * @return the number of trailing 9s that have to be present in the transaction hash to validate that proof of work


Suggested change

* @return the number of trailing 9s that have to be present in the transaction hash to validate that proof of work

* @return the number of trailing 9s that have to be present in the transaction hash to validate that enough proof of work

```?

changed to:

the minimal number of trailing 9s that have to be present at the end of the transaction hash in order to validate that sufficient proof of work has been done

src/main/java/com/iota/iri/TransactionValidator.java

alon-e · 2018-11-12T15:30:51Z

src/main/java/com/iota/iri/TransactionValidator.java

+     *     <li>Attempts to quickly solidify {@code transactionViewModel} by checking whether its direct parents
+     *     are soild. If solid we add it to the queue transaction solidification thread to help it propagate the
+     *     solidification to the approving child transactions</li>
+     *     <li>Requests missing transactions that are needed to solidify {@code transactionViewModel}</li>


these are only direct transactions, right?

yeah, will add

Co-Authored-By: GalRogozinski <[email protected]>

* Transaction Validator docs * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java * update ledger validator docs * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/TransactionValidator.java Co-Authored-By: GalRogozinski <[email protected]> * fix Transaction Validator documentation

Transaction Validator docs

843ab1a

GalRogozinski requested review from jakubcech and alon-e November 12, 2018 13:48

jakubcech approved these changes Nov 12, 2018

View reviewed changes

jakubcech and others added 17 commits November 12, 2018 16:57

Update src/main/java/com/iota/iri/TransactionValidator.java

9d1f3c5

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

7423461

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

09743a6

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

97ab104

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

7c20c2a

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

3d04111

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

6de42ca

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

232f756

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

96dfb35

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

c738368

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

1f19d08

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

5608711

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

0509a81

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

c09a368

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

6ab519b

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

a356688

update ledger validator docs

5761c81

alon-e suggested changes Nov 12, 2018

View reviewed changes

alon-e added the C-Docs label Nov 12, 2018

GalRogozinski assigned alon-e Nov 13, 2018

alon-e and others added 6 commits November 13, 2018 18:52

Update src/main/java/com/iota/iri/TransactionValidator.java

417dc88

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

5380ca4

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

0c3e89e

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

350571e

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

467709c

Co-Authored-By: GalRogozinski <[email protected]>

Update src/main/java/com/iota/iri/TransactionValidator.java

0def94c

Co-Authored-By: GalRogozinski <[email protected]>

fix Transaction Validator documentation

fbe1086

alon-e approved these changes Nov 14, 2018

View reviewed changes

alon-e merged commit 569d3af into iotaledger:dev Nov 14, 2018

GalRogozinski mentioned this pull request Dec 22, 2018

Release v1.5.6 #1251

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transaction Validator Documentation #1142

Transaction Validator Documentation #1142

GalRogozinski commented Nov 12, 2018

jakubcech Nov 12, 2018

alon-e Nov 12, 2018

GalRogozinski Nov 13, 2018

alon-e Nov 12, 2018

GalRogozinski Nov 13, 2018 •

edited

Loading

alon-e Nov 12, 2018

GalRogozinski Nov 13, 2018

	* <li>Sets the minimum weight magnitude. We validate POW on a transaction we will ascertain that it has
	* <li>Sets the minimum weight magnitude (MWM). When we validate POW on a transaction, we validate that it has

	* @return the number of trailing 9s that have to be present in the transaction hash to validate that proof of work
	* @return the number of trailing 9s that have to be present in the transaction hash to validate that enough proof of work
	```?

Transaction Validator Documentation #1142

Transaction Validator Documentation #1142

Conversation

GalRogozinski commented Nov 12, 2018

Description

Type of change

jakubcech Nov 12, 2018

Choose a reason for hiding this comment

alon-e Nov 12, 2018

Choose a reason for hiding this comment

GalRogozinski Nov 13, 2018

Choose a reason for hiding this comment

alon-e Nov 12, 2018

Choose a reason for hiding this comment

GalRogozinski Nov 13, 2018 • edited Loading

Choose a reason for hiding this comment

alon-e Nov 12, 2018

Choose a reason for hiding this comment

GalRogozinski Nov 13, 2018

Choose a reason for hiding this comment

GalRogozinski Nov 13, 2018 •

edited

Loading