Skip to content
This repository was archived by the owner on Aug 23, 2020. It is now read-only.

Feat: Making IRI use the initialSnapshot and the solidEntryPoints #1135

Conversation

hmoog
Copy link

@hmoog hmoog commented Nov 9, 2018

Description

This PR contains the changes that are necessary for checking against the solidEntryPoints instead of the NULL_HASH. It does not activate the creation of local snapshots, yet and also doesn't modify the LedgerValidator and MIlestoneTracker to change the "latestSnapshot" instance. The "initialSnapshot" that holds the solidEntryPoints is however read already from the new SnapshotProvider so this activates parts of the new code already. Since the "initialSnapshot" will be the last global snapshot (with the NULL_HASH as its only solidEntryPoint) in the absence of local snapshot files, it is a non-breaking change.

Once this PR is merged there will be a last PR that also enables the use of the "latestSnapshot" instance, which will fully enable the new features.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • All integration tests should succeed

Checklist:

Please delete items that are not relevant.

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
@iotaledger iotaledger deleted a comment Nov 12, 2018
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the little typo and we will merge

@GalRogozinski GalRogozinski merged commit b19fec0 into iotaledger:dev-localsnapshots Nov 12, 2018
@hmoog hmoog deleted the merge_initialsnapshot branch November 19, 2018 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants