This repository was archived by the owner on Aug 23, 2020. It is now read-only.
Document Bundle Validator #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should add some kind of descriptor for "consensus critical" code in the docs. |
|
We will create a custom annotation (@ConsensusCritical) to put over classes and methods |
alon-e
suggested changes
Nov 11, 2018
Co-Authored-By: GalRogozinski <[email protected]>
Co-Authored-By: GalRogozinski <[email protected]>
alon-e
suggested changes
Nov 11, 2018
alon-e
approved these changes
Nov 12, 2018
jakubcech
reviewed
Nov 12, 2018
| @@ -87,12 +136,13 @@ | |||
| digestTrits); | |||
| addressInstance.absorb(digestTrits,0, Curl.HASH_LENGTH); | |||
| offset = offsetNext; | |||
| } while (++j < instanceTransactionViewModels.size() | |||
| } //loop to traverse signature fragments divided between txs | |||
There was a problem hiding this comment.
Suggested change
| } //loop to traverse signature fragments divided between txs | |
| } //loop to traverse signature fragments divided between transactions |
|
|
||
| //verify bundle hash is correct | ||
| if (Arrays.equals(instanceTransactionViewModels.get(0).getBundleHash().trits(), bundleHashTrits)) { | ||
| //normalizing bundle in preparation for sig verification |
There was a problem hiding this comment.
Suggested change
| //normalizing bundle in preparation for sig verification | |
| //normalizing bundle in preparation for signature verification |
| @@ -101,23 +151,33 @@ | |||
| j++; | |||
| } | |||
| } | |||
|
|
|||
| //should only be reached after for loop is done | |||
There was a problem hiding this comment.
Suggested change
| //should only be reached after for loop is done | |
| //should only be reached after the above for loop is done |
| @@ -51,13 +95,15 @@ | |||
| instanceTransactionViewModels.get(0).setValidity(tangle, -1); | |||
There was a problem hiding this comment.
Is it worth adding a comment above that this is where we do the semantic checks?
Co-Authored-By: GalRogozinski <[email protected]>
Co-Authored-By: GalRogozinski <[email protected]>
Co-Authored-By: GalRogozinski <[email protected]>
Co-Authored-By: GalRogozinski <[email protected]>
Co-Authored-By: GalRogozinski <[email protected]>
Co-Authored-By: GalRogozinski <[email protected]>
Co-Authored-By: GalRogozinski <[email protected]>
DyrellC
pushed a commit
to DyrellC/iri
that referenced
this pull request
Nov 17, 2018
* document bundle validator * bundle validator documentation fixes * Fix grammar Co-Authored-By: GalRogozinski <[email protected]> * Fix sentence Co-Authored-By: GalRogozinski <[email protected]> * Fix Comments * Bundle Validator docs fixes * Update src/main/java/com/iota/iri/BundleValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/BundleValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/BundleValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/BundleValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/BundleValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/BundleValidator.java Co-Authored-By: GalRogozinski <[email protected]> * Update src/main/java/com/iota/iri/BundleValidator.java Co-Authored-By: GalRogozinski <[email protected]> * update bundle validator docs
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding documentation to bundle validator
Fixes #1107
Type of change