Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark-lint-no-dead-urls to detect dead links #921

Merged
merged 8 commits into from
Apr 17, 2023

Conversation

Dr-Electron
Copy link
Collaborator

@Dr-Electron Dr-Electron commented Apr 7, 2023

Description of change

Added the https://github.com/remarkjs/remark-lint-no-dead-urls plugin to detect broken links

TODO:

  • How do we report the vfile.message? How does docusaurus handle that?
  • Is it ok to work with the three year old version 1.1.0?
  • Any additional options we already know we would need to configure?
  • I guess we need to add this to all plugins separately?

Links to any relevant issues

Fixes #880

Type of change

  • Documentation Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@Dr-Electron Dr-Electron requested a review from jlvandenhout April 7, 2023 21:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

This pull request has been deployed to Vercel.

Latest commit: eaf9dab

✅ Preview: https://iota-wiki-gz03sdn70-iota1.vercel.app

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2584b89

✅ Preview: https://iota-wiki-3qeyvgog7-iota1.vercel.app

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: df5e4d1

✅ Preview: https://iota-wiki-h8rmcnyt5-iota1.vercel.app

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a6e1b32

✅ Preview: https://iota-wiki-9ryf5441n-iota1.vercel.app

@jlvandenhout jlvandenhout marked this pull request as ready for review April 15, 2023 23:36
@Dr-Electron Dr-Electron force-pushed the add-broken-url-detection branch from a6e1b32 to c656482 Compare April 17, 2023 20:08
@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c656482

✅ Preview: https://iota-wiki-pik5gyep7-iota1.vercel.app

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: fc16a91

✅ Preview: https://iota-wiki-lll45oozo-iota1.vercel.app

@Dr-Electron Dr-Electron merged commit 0ec0522 into main Apr 17, 2023
@Dr-Electron Dr-Electron deleted the add-broken-url-detection branch April 17, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for broken links
2 participants