Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC build in CI #1457

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

wulfraem
Copy link
Contributor

Description of change

PR fixes build issues for gRPC build by using same Ubuntu version as in other jobs.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix
  • CI

How the change has been tested

Checked against GitHub action run.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wulfraem wulfraem added No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. gRPC Related to the gRPC bindings code labels Nov 27, 2024
@wulfraem wulfraem requested a review from a team as a code owner November 27, 2024 15:58
@wulfraem wulfraem changed the base branch from feat/identity-rebased-alpha to main November 27, 2024 16:00
@wulfraem wulfraem marked this pull request as draft November 27, 2024 16:01
@wulfraem wulfraem marked this pull request as ready for review November 27, 2024 16:01
@wulfraem wulfraem changed the base branch from main to feat/identity-rebased-alpha November 27, 2024 18:02
@wulfraem wulfraem merged commit e9c6b78 into feat/identity-rebased-alpha Nov 28, 2024
14 of 16 checks passed
@wulfraem wulfraem self-assigned this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gRPC Related to the gRPC bindings code No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants