Replace deprecated workflow functions #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eike-hass
changed the title
eike-hass
changed the title
Co-authored-by: Philipp Gackstatter <[email protected]>
Co-authored-by: Philipp Gackstatter <[email protected]>
eike-hass
force-pushed
the
chore/update-workflows
branch
from
57a2ffb to
55c3b36
Compare
PhilippGackstatter
approved these changes
Feb 10, 2023
| @@ -58,4 +58,4 @@ jobs: | |||
| dprint check | |||
|
|
|||
| - name: cargo-license-template check | |||
| run: cargo license-template --template .license_template --ignore .license_template_ignore --verbose | |||
| run: cargo +nightly license-template --template .license_template --ignore .license_template_ignore --verbose | |||
There was a problem hiding this comment.
Probably doesn't matter if run with nightly because license-template should be agnostic over the environment, but also shouldn't be a problem.
olivereanderson
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Central workflow actions we use setup our rust tooling in CI have been unmaintained for a while. We need to move away from them since some of their dependencies and assumptions have bee deprecated by GitHub and might cease to work in the future.
The two noteworthy deprecations are:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Some alternatives (and general dissatisfaction) have been discussed in issues in the actions repositories:
actions-rs/toolchain#221
actions-rs/toolchain#219
Note:
We still need to find a replacement for actions-rs/audit-check which runs
cargo-auditin the background, but also handles GitHub specific reporting.The changes in this PR address the deprecations in our code and replace the
actions-rsactions. The toolchain setup is now done through a custom action in all places.Type of change
Add an
xto the boxes that are relevant to your changes.How the change has been tested
CI passes, although some workflows will only be triggered during a release, so there is some potential for things breaking still.
Change checklist
Add an
xto the boxes that are relevant to your changes.