Fix & allow clippy errors

* Fix clippy error writing `&Vec` instead of `&[_]` involves a new object where a slice will do * allow error clippy::too_many_arguments
iotaledger · Jan 7, 2025 · f46876f · f46876f
1 parent c1e4cbf
commit f46876f
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 5 deletions.
diff --git a/bindings/wasm/iota_interaction_ts/src/bindings/wasm_iota_client.rs b/bindings/wasm/iota_interaction_ts/src/bindings/wasm_iota_client.rs
@@ -134,7 +134,7 @@ impl ManagedWasmIotaClient {
   pub async fn execute_transaction_block(
     &self,
     tx_data_bcs: &TransactionDataBcs,
-    signatures: &Vec<SignatureBcs>,
+    signatures: &[SignatureBcs],
     options: Option<IotaTransactionBlockResponseOptions>,
     request_type: Option<ExecuteTransactionRequestType>,
   ) -> IotaRpcResult<IotaTransactionBlockResponseAdapter> {

diff --git a/bindings/wasm/iota_interaction_ts/src/iota_client_ts_sdk.rs b/bindings/wasm/iota_interaction_ts/src/iota_client_ts_sdk.rs
@@ -239,7 +239,7 @@ impl QuorumDriverTrait for QuorumDriverAdapter {
   async fn execute_transaction_block(
     &self,
     tx_data_bcs: &TransactionDataBcs,
-    signatures: &Vec<SignatureBcs>,
+    signatures: &[SignatureBcs],
     options: Option<IotaTransactionBlockResponseOptions>,
     request_type: Option<ExecuteTransactionRequestType>,
   ) -> IotaRpcResult<IotaTransactionBlockResponseAdaptedTraitObj> {

diff --git a/identity_iota_core/src/iota_interaction_rust/iota_client_rust_sdk.rs b/identity_iota_core/src/iota_interaction_rust/iota_client_rust_sdk.rs
@@ -135,7 +135,7 @@ impl<'a> QuorumDriverTrait for QuorumDriverAdapter<'a> {
   async fn execute_transaction_block(
     &self,
     tx_data_bcs: &TransactionDataBcs,
-    signatures: &Vec<SignatureBcs>,
+    signatures: &[SignatureBcs],
     options: Option<IotaTransactionBlockResponseOptions>,
     request_type: Option<ExecuteTransactionRequestType>,
   ) -> IotaRpcResult<IotaTransactionBlockResponseAdaptedTraitObj> {

diff --git a/identity_iota_interaction/src/iota_client_trait.rs b/identity_iota_interaction/src/iota_client_trait.rs
@@ -110,7 +110,7 @@ pub trait QuorumDriverTrait {
   async fn execute_transaction_block(
     &self,
     tx_data_bcs: &TransactionDataBcs,
-    signatures: &Vec<SignatureBcs>,
+    signatures: &[SignatureBcs],
     options: Option<IotaTransactionBlockResponseOptions>,
     request_type: Option<ExecuteTransactionRequestType>,
   ) -> IotaRpcResult<Box<dyn IotaTransactionBlockResponseT<Error = Self::Error, NativeResponse=Self::NativeResponse>>>;

diff --git a/identity_iota_interaction/src/move_call_traits.rs b/identity_iota_interaction/src/move_call_traits.rs
@@ -106,6 +106,11 @@ pub trait IdentityMoveCalls {
     package: ObjectID,
   ) -> Result<ProgrammableTransactionBcs, Self::Error>;
 
+  // We allow clippy::too_many_arguments here because splitting this trait function into multiple
+  // other functions or creating an options struct gathering multiple function arguments has lower
+  // priority at the moment.
+  // TODO: remove clippy::too_many_arguments allowance here
+  #[allow(clippy::too_many_arguments)]
   fn propose_config_change<I1, I2>(
     identity: OwnedObjectRef,
     controller_cap: ObjectRef,

diff --git a/identity_iota_interaction/src/sdk_types/generated_types.rs b/identity_iota_interaction/src/sdk_types/generated_types.rs
@@ -43,7 +43,7 @@ pub struct ExecuteTransactionBlockParams {
 impl ExecuteTransactionBlockParams {
   pub fn new(
     tx_bytes: &TransactionDataBcs,
-    signatures: &Vec<SignatureBcs>,
+    signatures: &[SignatureBcs],
     options: Option<IotaTransactionBlockResponseOptions>,
     request_type: Option<ExecuteTransactionRequestType>,
   ) -> Self {