fix: shift with BigInt instead of JS number #7703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bloom team encountered a bug with certain numbers that are decoded as 32-bit numbers instead of 64 numbers due to how JS number bitwise operations work. The solution was to convert all the values to
BigInt()
before executing bitwise operations.Ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Left_shift#description
...
Changelog
Testing
Platforms
Instructions
Run tests and try to send 10000999999 glow from L1 to L2.
...
Checklist