Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid setting state inside useFrame in Emitter #996

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Jan 23, 2024

Description of change

Resolves #947

Type of change

  • Enhancement (a non-breaking change which adds functionality)

@msarcev msarcev linked an issue Jan 23, 2024 that may be closed by this pull request
3 tasks
@msarcev msarcev requested a review from VmMad January 23, 2024 23:03
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfect! ❤️

@msarcev msarcev merged commit 6c79c5d into nova Jan 24, 2024
3 of 5 checks passed
@msarcev msarcev deleted the fix/avoid-state-in-useframe branch January 24, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Avoid using state inside useFrame
2 participants