Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Update shape of the tangle: star trail #924

Merged
merged 10 commits into from
Dec 20, 2023

Conversation

panteleymonchuk
Copy link
Collaborator

Description of change

fixes #892

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Open visualizer.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes

Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk panteleymonchuk changed the base branch from dev to nova December 13, 2023 17:17
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk panteleymonchuk force-pushed the feat/issue-892-update-shape-position branch from 79fdb54 to ec35d92 Compare December 13, 2023 17:18
VmMad
VmMad previously requested changes Dec 14, 2023
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the shape could be improved a bit, for example when the blocks per seconds is less, the "spray" should be smaller, and bigger if the bps is bigger. Atm it seems it keeps the same size. Also, the position in the BlockState is the finishing position? I think it would be nice to rename this property to something more specific, since we have initPosition too. Maybe currentPosition if it gets updated or finalPosition or targetPosition if it just contains the last position

@VmMad
Copy link
Member

VmMad commented Dec 14, 2023

Also, for some reason, when I change between tabs in my browser, the position of the blocks are different from the ones before
Screenshot from 2023-12-14 12-16-47

@panteleymonchuk
Copy link
Collaborator Author

@VmMad @begonaalvarezd @msarcev please, review one more time when you will be available

Here is screencast to show how it looks now
https://github.com/iotaledger/explorer/assets/25872497/746eebc5-39f7-48cb-9210-15876b266ab6

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼

@begonaalvarezd begonaalvarezd dismissed VmMad’s stale review December 20, 2023 17:00

please @VmMad lets discuss after christmas if you think there is something that should be improved here

@begonaalvarezd begonaalvarezd merged commit 72a6a6b into nova Dec 20, 2023
1 check passed
@begonaalvarezd begonaalvarezd deleted the feat/issue-892-update-shape-position branch December 20, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update shape of the tangle: star trail
3 participants