Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: polish lightning and add darkmode background #922

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Dec 13, 2023

Description of change

Move directionalLight position and intensity. Add darkmode background.

Fixes #906, fixes #907

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@begonaalvarezd begonaalvarezd merged commit 95180c0 into nova Dec 15, 2023
1 check passed
@begonaalvarezd begonaalvarezd deleted the feat/visualizer/polish-shading-material branch December 15, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Polish lighting and background [Task]: Polish block shading and material
3 participants