Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Rework format amount #824

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Fix: Rework format amount #824

merged 7 commits into from
Nov 16, 2023

Conversation

panteleymonchuk
Copy link
Collaborator

@panteleymonchuk panteleymonchuk commented Nov 13, 2023 •
edited
Loading

Description of change

  • Reworks formatAmount and adds tests
  • Fixes the edge case caused by JS floating point precision

Fix #822

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes

panteleymonchuk and others added 7 commits November 13, 2023 14:39
@panteleymonchuk
Output should be rounded by math rules instead of "round to floor".
63808fc 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
Revert changes. Change logic for format amount. Add tests.
18f7db1 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
Add tests.
eea8503 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
All tests passed (included tests before);
a70cd1e 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
Improve toFixedNoRound function.
c84e0d4 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@panteleymonchuk
Revert unchanged files.
1e4f989 
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@msarcev
feat: Improve valueFormatHelper test naming. Refactor naming. Fix tra…
b178935 
…nsactionHelper test unable to run with @iota/sdk-wasm
@msarcev msarcev changed the title Output should be rounded by math rules instead of "round to floor". Fix: Rework format amount Nov 16, 2023
@msarcev msarcev merged commit 2b481f6 into dev Nov 16, 2023
1 check passed
@msarcev msarcev deleted the feat/output-rounding branch November 16, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msarcev msarcev msarcev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: IOTA vs micro unit discrepancy
2 participants
@panteleymonchuk @msarcev