-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Visualizer Threejs (stardust) #809
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/visualizer-poc
…into feat/visualizer-poc
… instead of squares
…-out-tab Feat: Pause stream when window is out of focus
…eliably Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Feat: Add a BPS tracker to Visualizer
* (Fix) Improve zooming logic (from 5BPS to 100+BPS) and emitter position consistency with different zoom values. Implement coefficient for low bps. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * (Fix) Improve zooming logic (from 5BPS to 100+BPS) and emitter position consistency with different zoom values. Another algorighm for placing low bps Signed-off-by: Eugene Panteleymonchuk <[email protected]> --------- Signed-off-by: Eugene Panteleymonchuk <[email protected]>
* Prettier revert. pt1. * Prettier revert. pt2. * ESlint fixes. * Fixes after create PR. Remove more parts related to formatting.
* Test performance for render blocks. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Test performance when add in another way. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Remove blocks when they out of screen. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Refactoring Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Merged works. FPS awful. * Trying with bufferBeometry Signed-off-by: Eugene Panteleymonchuk <[email protected]> * With both examples. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Example with better performance. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * feat: Implement Tangle mesh using 'Instancing' (+ Refactor components). This makes the 'number of draw calls per render' constant and drastically improves performance * feat: Reimplement block scaling based on child references * chore: Rename states in store.ts * feat: Keep blockIdToIndex up to date properly (remove old elements) * fix: Scale the blocks properly --------- Signed-off-by: Eugene Panteleymonchuk <[email protected]> Co-authored-by: Eugene Panteleymonchuk <[email protected]>
Also fixes eslint warnings after eslint update Conflicts: client/package-lock.json client/package.json client/src/app/routes/stardust/Visualizer.tsx
* feat: Implement useRenderEdges * feat: Add removal of blocks edges when block is removed * feat: Hide all instances of InstancedMesh initialy (scale 0) * feat: Push useRenderEdges inside useRenderTangle (edge rendering DOESN'T work anymore because of timing issue of child no being in blockIdToIndex map yet) * feat: Introduce a map of blockId to position, and use it to simplify the useRenderEdges code (no need to read positions from InstancedMesh) * feat: Make edges rendering on demand (default disabled) controllable with checkbox in Wrapper
* Raycast get hovered id. * alternative. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Works better. Hover if isRunning. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Trying to remove color when blur. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Move onHover to separate hook. Revert disabling shift. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Clear hovered spheres. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Add onClick. Fixed glitching behaviour. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * fix: Fix code after base branch merge --------- Signed-off-by: Eugene Panteleymonchuk <[email protected]> Co-authored-by: Mario <[email protected]>
…#820) * Refactoring: create useConfigStore. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Fix eslint. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Move isRenderEdges inside hook. Signed-off-by: Eugene Panteleymonchuk <[email protected]> --------- Signed-off-by: Eugene Panteleymonchuk <[email protected]>
* feat: Remove the dynamic zoom as it's not needed (update the ZOOM_DEFAULT to a sensible value that works in all cases) * Fix reset camera to 0. Signed-off-by: Eugene Panteleymonchuk <[email protected]> --------- Signed-off-by: Eugene Panteleymonchuk <[email protected]> Co-authored-by: Eugene Panteleymonchuk <[email protected]>
* Show block meta on click. Signed-off-by: Eugene Panteleymonchuk <[email protected]> * Update position, change remove method. Signed-off-by: Eugene Panteleymonchuk <[email protected]> --------- Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Conflicts: client/package-lock.json client/package.json client/src/app/routes/stardust/Visualizer.tsx client/src/helpers/hooks/useVisualizerState.tsx client/tsconfig.json
3 tasks
begonaalvarezd
changed the title
Feat: Visualizer Threejs
Feat: Visualizer Threejs (stardust)
Dec 5, 2023
…hree. Split the scss for stardust/nova visualizers
3 tasks
begonaalvarezd
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Please write a summary of your changes and why you made them. Be sure to reference any related issues by adding
fixes # (issue)
.Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an
x
to the boxes that are relevant to your changes, and delete any items that are not.