Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metric units to nova landing page #1475

Merged
merged 6 commits into from
May 13, 2024
Merged

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented May 13, 2024

Description of change

Fixes #1470

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad VmMad requested a review from panteleymonchuk May 13, 2024 10:37
@VmMad VmMad changed the title feat: add metric units to landing page feat: add metric units to nova landing page May 13, 2024
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@begonaalvarezd begonaalvarezd merged commit 8ba5942 into main May 13, 2024
6 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/add-metric-units branch May 13, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add metric units to landing stats
4 participants