-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: polish balance page #1370
Conversation
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve conflicts please 🙏
it makes sense to me |
# Conflicts: # client/src/app/components/nova/address/AddressBalance.tsx
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@brancoder
|
@panteleymonchuk There's something weird with storage deposit on this address |
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 extra small details
- We should unify showing always unit when 0 or not so we avoid these situations
- The copy feature could be improved so you always copy the "raw amount", the syll amount in the subunit unit, without the ticker, so you copy the full value number, and not a string, eg if the balance is 1.123 TST the value copied should be
1123000
instead of1.123 TST
… mana. Signed-off-by: Eugene Panteleymonchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented in slack, lets detatch the unit toggles from different boxes
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of change
Closes #1352
Type of change
How the change has been tested
Take a look address page.
Desktop
Tablet
Change checklist
Add an
x
to the boxes that are relevant to your changes, and delete any items that are not.