Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Polish Nova Output Page #1318

Merged
merged 19 commits into from
Mar 27, 2024
Merged

Chore: Polish Nova Output Page #1318

merged 19 commits into from
Mar 27, 2024

Conversation

brancoder
Copy link
Collaborator

Description of change

closes #1305

Type of change

  • Enhancement (a non-breaking change which adds functionality)

@brancoder brancoder linked an issue Mar 21, 2024 that may be closed by this pull request
8 tasks
@brancoder brancoder marked this pull request as ready for review March 22, 2024 12:23
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a mini comment, but everything works very nicely. With the mana units added to the total mana & the CI fixed, we can merge 🌷

client/src/helpers/nova/manaUtils.tsx Outdated Show resolved Hide resolved
 Conflicts:
	client/src/helpers/stardust/valueFormatHelper.tsx
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The total mana doesnt add up 🙏🏼
image
output 0xda6e52e4e01393beaf2ccc56a83ca85d63f45dd82274ed4ab17912b7b77a60f8ba8a00000000

@msarcev
Copy link
Collaborator

msarcev commented Mar 26, 2024

The total mana doesnt add up 🙏🏼 image output 0xda6e52e4e01393beaf2ccc56a83ca85d63f45dd82274ed4ab17912b7b77a60f8ba8a00000000

Consequence of typescript being a joke. The types in the source are a "hopefully is this type" at best.

@begonaalvarezd begonaalvarezd merged commit 9f655ee into dev Mar 27, 2024
4 of 6 checks passed
@begonaalvarezd begonaalvarezd deleted the chore/polish-output-page branch March 27, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Polish Output page
3 participants