Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Improve rendering of tabbed section initial state #1287

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix: Improve rendering of tabbed section initial state #1287

merged 1 commit into from
Mar 12, 2024

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Mar 12, 2024

Description of change

Tabbed section need the "first" tab to be always enabled

  • Rearranged the ordering of tabs so that all cases have an enable first tab that can be selected by default

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

@brancoder brancoder self-requested a review March 12, 2024 11:48
brancoder
brancoder approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brancoder brancoder merged commit 38d5c11 into dev Mar 12, 2024
4 of 6 checks passed
@brancoder brancoder deleted the fix/select-default-tab-open branch March 12, 2024 11:48
@brancoder brancoder linked an issue Mar 21, 2024 that may be closed by this pull request
[Task]: Always display the tx tab #1261
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancoder brancoder brancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Always display the tx tab
2 participants
@msarcev @brancoder