-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kick off vivagraph. #1284
Conversation
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small suggestions
client/src/features/visualizer-vivagraph/VisualizerInstance.tsx
Outdated
Show resolved
Hide resolved
client/src/features/visualizer-vivagraph/VisualizerInstance.tsx
Outdated
Show resolved
Hide resolved
client/src/features/visualizer-vivagraph/components/KeyPanel.tsx
Outdated
Show resolved
Hide resolved
client/src/features/visualizer-vivagraph/definitions/constants.ts
Outdated
Show resolved
Hide resolved
client/src/features/visualizer-vivagraph/definitions/constants.ts
Outdated
Show resolved
Hide resolved
client/src/features/visualizer-vivagraph/components/SelectedFeedInfo.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missclick 🔝
Also, you might need to run format, bc there are some prettier issues in some files |
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
980ef53
to
1ef7415
Compare
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good but one of the things we should do, if not in this PR, in a later cleanup PR, is to move this to nova
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Description of change
Closes #1266
Type of change
How the change has been tested
Open visualizer page for nova.
Change checklist
Add an
x
to the boxes that are relevant to your changes, and delete any items that are not.