Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kick off vivagraph. #1284

Merged
merged 7 commits into from
Mar 14, 2024
Merged

feat: kick off vivagraph. #1284

merged 7 commits into from
Mar 14, 2024

Conversation

panteleymonchuk
Copy link
Collaborator

Description of change

Closes #1266

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Open visualizer page for nova.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small suggestions

client/src/features/visualizer-vivagraph/hooks/useFeed.ts Outdated Show resolved Hide resolved
client/src/features/visualizer-vivagraph/lib/helpers.ts Outdated Show resolved Hide resolved
client/src/services/nova/novaFeedClient.ts Outdated Show resolved Hide resolved
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missclick 🔝

@VmMad
Copy link
Member

VmMad commented Mar 13, 2024

Also, you might need to run format, bc there are some prettier issues in some files

Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but one of the things we should do, if not in this PR, in a later cleanup PR, is to move this to nova

client/src/helpers/nodeShader.ts Outdated Show resolved Hide resolved
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
@begonaalvarezd begonaalvarezd merged commit 090c908 into dev Mar 14, 2024
4 of 6 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/issues-1266 branch March 14, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants