Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve expiration and timelock unlock conditions #1259

Merged
merged 3 commits into from
Mar 5, 2024
Merged

feat: Improve expiration and timelock unlock conditions #1259

merged 3 commits into from
Mar 5, 2024

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Mar 5, 2024 •
edited
Loading

Description of change

  • Added icons (with Tooltip) to OutputView for outputs with "special" unlock conditions
  • Added outputUtils with capability of checking if an CommonOutput isExpired and isTimeLocked
  • Color of icon depends if EUC is expired (or timelocked)

Closes #1087

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

  • Need an Output with actual Expiration unlock condition to test this!! (Blocked)
  • Need an Output with actual TimeLock unlock condition to test this!! (Blocked)

@msarcev
feat: Add special unlock condition icon to output header in OutputVie…
8e842c0 
…w. Add util for checking if a CommonOutput isExpired.
@msarcev msarcev linked an issue Mar 5, 2024 that may be closed by this pull request
[Task]: Update expiration unlock condition to new TIPs #1087
Closed
@msarcev msarcev changed the title feat: Improve expiration unlock condition feat: Improve expiration and timelock unlock conditions Mar 5, 2024
@msarcev msarcev linked an issue Mar 5, 2024 that may be closed by this pull request
[Task]: Update time unlock condition to new TIPs #1088
Closed
@begonaalvarezd begonaalvarezd merged commit 6c9442e into dev Mar 5, 2024
4 of 6 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/update-expiration-unlock-condition branch March 5, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Update time unlock condition to new TIPs [Task]: Update expiration unlock condition to new TIPs
2 participants
@msarcev @begonaalvarezd