Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync sdk types #1211

Merged
merged 9 commits into from
Mar 4, 2024
Merged

chore: sync sdk types #1211

merged 9 commits into from
Mar 4, 2024

Conversation

begonaalvarezd
Copy link
Member

@begonaalvarezd begonaalvarezd commented Mar 3, 2024

Description of change

Close #1210
Blocked until the SDK includes missing functions and exports needed

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • [] My code follows the contribution guidelines for this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes

@begonaalvarezd begonaalvarezd self-assigned this Mar 3, 2024
@begonaalvarezd begonaalvarezd linked an issue Mar 3, 2024 that may be closed by this pull request
@begonaalvarezd begonaalvarezd marked this pull request as ready for review March 4, 2024 14:58
@begonaalvarezd begonaalvarezd requested a review from msarcev March 4, 2024 14:58
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brancoder brancoder merged commit b7fdcc6 into dev Mar 4, 2024
4 of 6 checks passed
@brancoder brancoder deleted the chore/sync-sdk-types branch March 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Adapt to latest SDK
3 participants