fix(visualizer): paused visualizer behaves weirdly when reaching max blocks #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
# Conflicts: # client/src/features/visualizer-threejs/VisualizerInstance.tsx # client/src/features/visualizer-threejs/store/tangle.ts # client/src/features/visualizer-threejs/wrapper/Wrapper.tsx
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
VmMad
previously requested changes
Mar 1, 2024
There was a problem hiding this comment.
@panteleymonchuk I think this issue needs more work.
You correctly fixed the blocks changing colors, but when you pause the visualizer, the blocks instances are still being updated (even thought the colors arent) so, to explain this better I'll give you some steps to replicate what i mean:
- Let the visualizer run until max blocks and then pause it.
- You will have to wait a lot, but in the meanwhile, you can click a block close to the end of the screen. You will see the block info popup. That is correct.
- Wait a lot more, so until it would start painting colors as pending like previously. You will see the color is not changing, but the block info dissapears. Click a block closer to the emitter and you will see the popup, but it will dissapear soon.
I think we need to try to avoid updating the block instances when the visualizer is paused, and maybe if the instance is not updated, the color won't change anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Closes #1178
Type of change
How the change has been tested
When user pause visualizer and wait, after some time user see changes color from left to right.
This is because we don't stop stream and overwrite values by index.
Expected result:
when visualizer paused update only visible blocks
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.