Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Improve Address conversions #1194

Merged
merged 8 commits into from
Feb 28, 2024
Merged

Fix: Improve Address conversions #1194

merged 8 commits into from
Feb 28, 2024

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Feb 27, 2024

Description of change

  • Improve api/client addressHelper by using the new addressToBech32 SDK method
  • Small fixes

Type of change

  • Enhancement (a non-breaking change which adds functionality)

@msarcev
chore: Bump sdk-nova version to latest commit
2604583
@msarcev
chore: Improve nova address helper
a5fe19d
@msarcev
Merge branch 'dev' into fix/adapt-sdk-util-changes
cc48a9b 
 Conflicts:
	.github/workflows/nova-build-temp.yaml
	client/src/helpers/nova/addressHelper.ts
	setup_nova.sh
@msarcev msarcev marked this pull request as draft February 27, 2024 18:07
@msarcev msarcev marked this pull request as ready for review February 28, 2024 08:43
@msarcev msarcev requested a review from brancoder February 28, 2024 08:43
brancoder
brancoder approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begonaalvarezd begonaalvarezd self-requested a review February 28, 2024 09:38
@brancoder brancoder self-requested a review February 28, 2024 10:22
brancoder
brancoder requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add changes to address calculation in Nft.txs. Change hexToBech32 -> addressToBech32

  • OutputView component has Alias in function name buildAddressForAliasOrNft

@brancoder brancoder self-requested a review February 28, 2024 10:30
brancoder
brancoder approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brancoder brancoder merged commit f124557 into dev Feb 28, 2024
4 of 6 checks passed
@brancoder brancoder deleted the fix/adapt-sdk-util-changes branch February 28, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancoder brancoder brancoder approved these changes

@begonaalvarezd begonaalvarezd Awaiting requested review from begonaalvarezd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msarcev @brancoder