Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add search by delegation id #1176

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Conversation

brancoder
Copy link
Collaborator

Description of change

resolves #1152

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@brancoder brancoder linked an issue Feb 23, 2024 that may be closed by this pull request
@panteleymonchuk
Copy link
Collaborator

@brancoder could you clarify if this mentioned route in description already exists in dev branch? Or we still need to add it?

#1152
...and route to Output Page

@brancoder
Copy link
Collaborator Author

@brancoder could you clarify if this mentioned route in description already exists in dev branch? Or we still need to add it?

#1152 ...and route to Output Page

The Output Page is already there. The task was just to search for delegation output by delegation id and, if found, show user the Output Page.

@brancoder brancoder marked this pull request as draft February 26, 2024 15:42
@brancoder brancoder force-pushed the feat/add-delegation-search branch from 4be9765 to c44dbd7 Compare February 26, 2024 15:46
@brancoder brancoder marked this pull request as ready for review February 26, 2024 15:47
@begonaalvarezd begonaalvarezd merged commit ae55f70 into dev Feb 26, 2024
4 of 6 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/add-delegation-search branch February 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Support search by delegation ID
3 participants