Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make scene vertical in vertical screens #1161

Merged
merged 5 commits into from
Feb 22, 2024
Merged

feat: make scene vertical in vertical screens #1161

merged 5 commits into from
Feb 22, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Feb 20, 2024

Description of change

Fixes #1125

Type of change

  • Enhancement

How the change has been tested

Chrome DevTools, just make the screen like it was a mobile

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad VmMad linked an issue Feb 20, 2024 that may be closed by this pull request
[Task]: Add top-to-bottom plotting #1125
Closed
2 tasks
@VmMad VmMad changed the title feat: allow vertical scenes of small screens feat: make scene vertical in small screens Feb 20, 2024
msarcev
msarcev previously requested changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@msarcev msarcev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix conflicts.

@VmMad VmMad requested a review from msarcev February 22, 2024 13:18
begonaalvarezd
begonaalvarezd approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@begonaalvarezd begonaalvarezd dismissed msarcev’s stale review February 22, 2024 17:03

PR works and conflicts are solved 🙏

@begonaalvarezd begonaalvarezd changed the title feat: make scene vertical in small screens feat: make scene vertical in vertical screens Feb 22, 2024
@begonaalvarezd begonaalvarezd merged commit 1e8b18d into dev Feb 22, 2024
4 of 6 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/nova-visualizer/add-mobile-plotting branch February 22, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@panteleymonchuk panteleymonchuk Awaiting requested review from panteleymonchuk

@msarcev msarcev Awaiting requested review from msarcev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add top-to-bottom plotting
3 participants
@VmMad @begonaalvarezd @msarcev