Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update blocks metadata on paused visualizer #1111

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Feb 12, 2024

Description of change

Fixes #915

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VmMad VmMad linked an issue Feb 12, 2024 that may be closed by this pull request
3 tasks
@panteleymonchuk
Copy link
Collaborator

For some reason updates doesn't work when I switch to another tab (I simulated it by pressing debug tools).
And when I play again, I don't see new blocks

review.PR.1111.mp4

@msarcev
Copy link
Collaborator

msarcev commented Feb 13, 2024

Code LGTM. @panteleymonchuk are you happy with it ?

@panteleymonchuk
Copy link
Collaborator

Updating when pause now works properly.
However when we play again I see bunch of data. Does it expected behaviour?
https://github.com/iotaledger/explorer/assets/25872497/c0cbf81f-400b-4f6c-a4ed-bd845739c200

@begonaalvarezd begonaalvarezd merged commit 788ea46 into dev Feb 14, 2024
3 of 5 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/play-pause-visualizer branch February 14, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix confirmed blocks not showing up after pausing visualizer
4 participants