Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Block issuer key render #1029

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Fix: Block issuer key render #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e57e440
fix: Fix render of BlockIssuerKey on OutputPage
msarcev Jan 30, 2024
e0f5561
fix: Fix import for BlockIssuerKey (Bumps SDK to latest commit)
msarcev Jan 30, 2024
33b0419
fix: conflict resolved
brancoder Jan 31, 2024
e36161b
fix: update sdk commit hash in the nova build template yaml
brancoder Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nova-build-temp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
TARGET_COMMIT:
description: "Target Commit Hash for the SDK"
required: false
default: "05b7cec884177ba11c8848d0d52c850a8bb496fe"
default: "08318f6e3f92af609b89c571462ea31b32e7c121"
environment:
type: choice
description: "Select the environment to deploy to"
Expand Down
5 changes: 2 additions & 3 deletions client/src/app/components/nova/FeaturesView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {
BlockIssuerFeature,
Ed25519PublicKeyHashBlockIssuerKey,
Feature,
FeatureType,
IssuerFeature,
Expand All @@ -9,8 +10,6 @@ import {
StakingFeature,
TagFeature,
} from "@iota/sdk-wasm-nova/web";
// will this import work ? why isnt it exported from web ?
import { Ed25519BlockIssuerKey } from "@iota/sdk-wasm-nova/web/lib/types/block/output/block-issuer-key";
import classNames from "classnames";
import React, { useState } from "react";
import AddressView from "./address/AddressView";
Expand Down Expand Up @@ -75,7 +74,7 @@ const FeatureView: React.FC<FeatureViewProps> = ({ feature, isImmutable, isPreEx
<div className="card--label">Block issuer keys:</div>
{Array.from((feature as BlockIssuerFeature).blockIssuerKeys).map((blockIssuerKey, idx) => (
<div key={idx} className="card--value row">
{(blockIssuerKey as Ed25519BlockIssuerKey).publicKey}
{(blockIssuerKey as Ed25519PublicKeyHashBlockIssuerKey).pubKeyHash}
</div>
))}
</div>
Expand Down
Loading