Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support rewards mana on delegation output #1017

Merged
merged 8 commits into from
Jan 31, 2024

Conversation

msarcev
Copy link
Collaborator

@msarcev msarcev commented Jan 26, 2024

Description of change

  • Add support for rewards on delegation output

⚠️ Based on #1016

Closes #1001

Type of change

  • Enhancement (a non-breaking change which adds functionality)

@msarcev msarcev linked an issue Jan 26, 2024 that may be closed by this pull request
@brancoder brancoder self-requested a review January 30, 2024 16:30
 Conflicts:
	client/src/app/routes/nova/OutputPage.tsx
	client/src/helpers/nova/manaUtils.ts
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just minor comment changes needed

api/src/services/nova/novaApiService.ts Outdated Show resolved Hide resolved
client/src/helpers/nova/hooks/useOutputManaRewards.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brancoder brancoder merged commit 0c85efc into dev Jan 31, 2024
3 of 5 checks passed
@brancoder brancoder deleted the feat/support-rewards-mana-on-delegation-output branch January 31, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add mana to the output page: total with delegation rewards
2 participants