Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arrays for batched CurlP #719

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Use arrays for batched CurlP #719

merged 1 commit into from
Sep 9, 2021

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Sep 8, 2021

Description of change

Add a BcTritArr<N> struct akin to [u8; N] to avoid heap allocations and dereferences while hashing.

This improves performance from 3 to 5% according to the benchmarks.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Using the existing test and benchmark suite

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@pvdrz pvdrz requested a review from Alex6323 as a code owner September 8, 2021 15:29
@thibault-martinez thibault-martinez merged commit a48d1d8 into iotaledger:dev Sep 9, 2021
@pvdrz pvdrz deleted the batched-curl-const-generics branch October 12, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants