Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix milestone timestamp in API #1322

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Fix milestone timestamp in API #1322

merged 3 commits into from
Apr 4, 2022

Conversation

thibault-martinez
Copy link
Member

@thibault-martinez thibault-martinez commented Apr 4, 2022 •
edited
Loading

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@thibault-martinez thibault-martinez added wg-api Working Group - API c-bug Category - Bug e-low Experience - Low p-critical Priority - Critical n-all Network - All labels Apr 4, 2022
@samuel-rufi samuel-rufi self-requested a review April 4, 2022 07:30
@thibault-martinez thibault-martinez merged commit e7f3540 into iotaledger:mainnet-develop-0.3.1 Apr 4, 2022
@thibault-martinez thibault-martinez deleted the fix-milestone-api branch April 4, 2022 09:28
@thibault-martinez thibault-martinez added this to the v0.3 milestone Apr 4, 2022
thibault-martinez added a commit that referenced this pull request May 9, 2022
@thibault-martinez @Alex6323
Fix /api/v1/milestone response (#1401)
af99222 
* Fix milestone timestamp in API (#1322)

* Fix milestone timestamp in API

* Fmt

* Update bee-api/bee-rest-api/src/endpoints/routes/api/v1/milestone.rs

Co-authored-by: /alex/ <[email protected]>

Co-authored-by: /alex/ <[email protected]>

* bee-node-0.3.1 (#1323)

Co-authored-by: /alex/ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

Assignees
No one assigned
Labels
c-bug Category - Bug e-low Experience - Low n-all Network - All p-critical Priority - Critical wg-api Working Group - API
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@thibault-martinez @samuel-rufi @Alex6323 @Thoralf-M