-
-
Notifications
You must be signed in to change notification settings - Fork 518
Conversation
c05b0e3
to
d6d4660
Compare
b365398
to
8fbe0df
Compare
302e6d6
to
0f6547f
Compare
0f6547f
to
c58b866
Compare
7a95d42
to
a71aabc
Compare
87448c6
to
28a5f46
Compare
28a5f46
to
3413d59
Compare
b36eb9a
to
36c980b
Compare
baed4d5
to
3d9d9c2
Compare
// key = dc/ion-sfu-1/room1/uid | ||
// value = [...stream/track info ...] | ||
func (s *islbServer) PostISLBEvent(ctx context.Context, event *proto.ISLBEvent) (*ion.Empty, error) { | ||
log.Infof("ISLBServer.PostISLBEvent: %v", event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very cool - By posting the event into redis, you have created a way for external applications to "listen" and detect new streams; for example, we could now write a fully external service that watches redis keys "dc1/sfu/test session/*" and sends signal to start elements.SaveToWebm
process in AVP server (to automatically record all streams in a call, for example)
WITH THIS PR ION SIGNALING IS DEPRECATING JSONRPCThis PR generated a lot of discussion in our slack channel (#ion on the Gophers slack, join us!) regarding the deprecation of
This decision is not made lightly, and we recognize that some of the community still has a strong preference for Users who want to avoid writing grpc clients could build a simple bridge for these purposes with https://github.com/grpc-ecosystem/grpc-gateway or https://github.com/google/rejoiner (or by implementing a jsonrpc server with NOTE: THIS ONLY APPLIES TO |
LGTM!Great work!Let's support grpc frist:
In addition, I think we will discuss later to unify the message keywords and signaling process of grpc and json in ion-sfu, so that we can convert the two protocols more easily in the biz signaling bridge. For example, the description in grpc and the offer/answer in json-rpc are not consistent. |
After this, also need: |
This reverts commit c78de87.
Changes:
Support grpc/http2 and grpc-web/websockets at the same time
Client SDK Update
Added IonConnector interface for connecting ion cluster
Biz signaling only has 3 methods:
And 5 main events:
The authentication interface (jwt or other method) can be independently created and implemented by the auth.proto grpc service.