-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow layer selection for publisher #175
Conversation
7499d33
to
98cfe8d
Compare
Just to make sure i understand, is this so the sfu can tell the client which layers to send? |
This change allows the publisher to select which layer(s) should be enabled. Right now if I select FHD, I will send 3 layers all the time. If I want to change that, I'll have to renegotiate. With this change, the publisher can enable/disable the layer on the fly. An additional message is needed because there is no (easy) way for ion-sfu to detect that layer has been disabled. Once we send message of new layer selection, ion-sfu will check all the down tracks and update accordingly. New channel message activeLayer is for informational purposes only, so that subscribers are aware. |
This force subscriber to use one layer? |
I think the SFU needs to do active track detection. Even without this change it is necessary since the browser can automatically toggle layers without user input. I think @OrlandoCo has plans to implement support for it at some point. My preference would be to wait for that since it avoids a lot of clientside/signaling complexity |
* Export Layer type * Allow tweaking encoding params per layer by using optional layer param. This can be used to disable certain layer (for example keep high layer disabled and enable it only for main speaker) * Adding support for active layer channel message Support legacy channel message
9cd6c67
to
4e30f57
Compare
Related to: ionorg/ion-sfu#477
Description
Reference issue
Fixes #...