-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Dockerfile #119
fix Dockerfile #119
Conversation
also closes #122 |
- add sass package that do not require binary deps (node-gyp_ - remove unused deps from dockerfile - use LTS node version in Dockerfile - use `npm ci` instead of npm i
9525bdc
to
f55a982
Compare
@adwpc |
@gcavanunez Thanks for #122 !
@kangshaojun is origin author, advise to just keep sass |
Then probably we can merge that PR? Or there are some change requests? |
@nosovk got these error when use docker with chrome: |
@adwpc you have to launch ion backend on localhost to avoide that problem and update caddyconfig: https://github.com/pion/ion-app-web/blob/eb384c0ee580cdadcd8a20e7dfbbc9f1657d5949/prod.Caddyfile#L7 Probably we should update documentation to explain that part of config should be updated in that file during deploy. |
npm ci
instead of npm iDescription
Reference issue
Fixes #...
#117
#99
#94
Closes: #113