Dotnet 7 #176
Dotnet 7 #176
Conversation
TheAngryByrd
force-pushed
the
dotnet-7
branch
from
649e3a4 to
6266e2d
Compare
| @@ -8,5 +8,5 @@ | |||
| "test/examples", | |||
| "packages" | |||
| ], | |||
| "editor.formatOnSave": true | |||
| } | |||
| // "editor.formatOnSave": true | |||
There was a problem hiding this comment.
Probably need to update fantomas to 5.x because otherwise this seems to break formatting on test files.
| source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json | ||
| source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7-transport/nuget/v3/index.json |
There was a problem hiding this comment.
Sources for hidden Microsoft.Build dlls that preview bits of F# 7 depend on. We probably gotta wait for these previews to be available.
| nuget FSharp.Core 7.0.0-beta.22473.1 | ||
| nuget FSharp.Compiler.Service 42.7.100-preview.22473.1 |
There was a problem hiding this comment.
Getting the latest bits. FSAC is gonna have a big diff with this.
| @@ -16,13 +20,14 @@ nuget Ionide.KeepAChangelog.Tasks copy_local:true | |||
| nuget Expecto | |||
| nuget Expecto.Diff | |||
| nuget Expecto.TestResults | |||
| nuget MedallionShell ~> 1.5.0 | |||
| nuget MedallionShell | |||
There was a problem hiding this comment.
This has some weird transitive dependencies so I had to remove the constraint. It looks kind of outdated so we may want to consider something else in the future.
| nuget Microsoft.Build 17.4.0-preview-22469-04 copy_local: false | ||
| nuget Microsoft.Build.Framework 17.4.0-preview-22469-04 copy_local: false | ||
| nuget Microsoft.Build.Utilities.Core 17.4.0-preview-22469-04 copy_local: false | ||
| nuget Microsoft.Build.Tasks.Core 17.4.0-preview-22469-04 copy_local: false | ||
| nuget Microsoft.NET.StringTools 17.4.0-preview-22469-04 |
There was a problem hiding this comment.
Had to specify all these exactly because paket wasn't downloading them for some reason.
| | None -> | ||
| match args.TryGetResult Solution with | ||
| | None -> Seq.empty | ||
| (*match args.TryGetResult Solution with |
There was a problem hiding this comment.
I should put these back
| projects |> Seq.map snd |> Seq.collect (fun x -> x.Items) |> Seq.map(fun ii -> ii.ItemType, ii.EvaluatedInclude) |> Newtonsoft.Json.JsonConvert.SerializeObject |> printfn "%s" | ||
| projects |> Seq.map snd |> Seq.collect (fun x -> x.Properties) |> Seq.map(fun ii -> ii.Name, ii.EvaluatedValue) |> Newtonsoft.Json.JsonConvert.SerializeObject |> printfn "%s" |
There was a problem hiding this comment.
Added ability to get the ProjectInstance Items and Properties for further debugging.
There was a problem hiding this comment.
Maybe should be behind another flag?
| let buildProjs = | ||
| result.ResultsByNode.Keys | ||
| |> Seq.collect (fun (pgn: ProjectGraphNode) -> seq { yield pgn.ProjectInstance }) | ||
| |> Seq.toList | ||
|
|
There was a problem hiding this comment.
Had to move this because this could fail before we log the error from the design time build. Could add another log for how many we parsed.
| @@ -1407,7 +1413,7 @@ let tests toolsPath = | |||
| testProjectSystemOnChange toolsPath "WorkspaceLoader" WorkspaceLoader.Create | |||
| testProjectSystemOnChange toolsPath "WorkspaceLoaderViaProjectGraph" WorkspaceLoaderViaProjectGraph.Create | |||
| debugTests toolsPath "WorkspaceLoader" WorkspaceLoader.Create | |||
| debugTests toolsPath "WorkspaceLoaderViaProjectGraph" WorkspaceLoaderViaProjectGraph.Create | |||
| // debugTests toolsPath "WorkspaceLoaderViaProjectGraph" WorkspaceLoaderViaProjectGraph.Create | |||
There was a problem hiding this comment.
Need to add this back in
| @@ -1242,7 +1242,7 @@ let testProjectSystemOnChange toolsPath workspaceLoader workspaceFactory = | |||
| ) | |||
|
|
|||
| let debugTests toolsPath workspaceLoader (workspaceFactory: ToolsPath -> IWorkspaceLoader) = | |||
| ptestCase | |||
| ftestCase | |||
No description provided.