chore(build): remove sourcemaps, minified compiler build

[alicewriteswrongs]

This removes sourcemaps from the cli, compiler, and dev-server bundles and also removes the unused minified compiler build. All these changes are made to the esbuild-based build.

We realized recently that the minified compiler is no longer necessary (it was previously used for in-browser compilation support, and was removed in #4317) and the sourcemaps are similarly not useful, but do take up a significant amount of space.

Without this change a packed Stencil tarball is around 12MB, and with this change it drops to 3.5MB.

STENCIL-1242

Documentation

Does this introduce a breaking change?

• Yes
• No

Testing

Test that you can build and use Stencil with this change.

Also try out the 'debug' build, which is building like so:

DEBUG=true npm run build

that should produce sourcemaps for all the files bundled with Esbuild.

[github-actions]

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1137 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files

Path	Error Count
src/dev-server/index.ts	37
src/dev-server/server-process.ts	32
src/compiler/prerender/prerender-main.ts	22
src/runtime/client-hydrate.ts	20
src/testing/puppeteer/puppeteer-element.ts	20
src/screenshot/connector-base.ts	19
src/runtime/vdom/vdom-render.ts	17
src/dev-server/request-handler.ts	15
src/compiler/prerender/prerender-optimize.ts	14
src/compiler/sys/stencil-sys.ts	14
src/sys/node/node-sys.ts	14
src/compiler/prerender/prerender-queue.ts	13
src/compiler/sys/in-memory-fs.ts	13
src/runtime/connected-callback.ts	13
src/runtime/set-value.ts	13
src/compiler/output-targets/output-www.ts	12
src/compiler/transformers/test/parse-vdom.spec.ts	12
src/compiler/transformers/transform-utils.ts	12
src/compiler/transpile/transpile-module.ts	12
src/mock-doc/test/attribute.spec.ts	12

Our most common errors

Typescript Error Code	Count
TS2322	361
TS2345	344
TS18048	204
TS18047	82
TS2722	37
TS2532	24
TS2531	21
TS2454	14
TS2790	11
TS2352	9
TS2769	8
TS2538	8
TS2416	7
TS2493	3
TS18046	2
TS2684	1
TS2430	1

Unused exports report

There are 14 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports

File	Line	Identifier
src/runtime/bootstrap-lazy.ts	21	setNonce
src/screenshot/screenshot-fs.ts	18	readScreenshotData
src/testing/testing-utils.ts	198	withSilentWarn
src/utils/index.ts	145	CUSTOM
src/utils/index.ts	269	normalize
src/utils/index.ts	7	escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts	25	BUILD
src/compiler/app-core/app-data.ts	115	Env
src/compiler/app-core/app-data.ts	117	NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts	123	updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts	61	satisfies
src/compiler/types/validate-primary-package-output-target.ts	61	Record
src/testing/puppeteer/puppeteer-declarations.ts	485	WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts	7	writeFetchSuccessSync

[github-actions]

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/8633844862/artifacts/1401993138

If your browser saves files to ~/Downloads you can install it like so:

unzip -d ~/Downloads ~/Downloads/stencil-core-4.15.0-dev.1712762818.04c44c7.tgz.zip && npm install ~/Downloads/stencil-core-4.15.0-dev.1712762818.04c44c7.tgz

[rwaskiewicz]

I did a search for stencil.min.js across the entire Ionic Org in GitHub, and found a couple of places I think we should also look into as a part of this effort:

1. This section of the Stencil Site. I think that we can safely remove the offending sentence in the same files that Christian updated in ionic-team/stencil-site@999d831

2. We still have a reference to this file in the compiler itself, at

   stencil/src/compiler/sys/stencil-sys.ts

   Line 146 in b3886aa

   return sys.getRemoteModuleUrl({ moduleId: '@stencil/core', path: 'compiler/stencil.min.js' });

   . I wonder if we overlooked the possibility of pulling in Stencil from a CDN in a way that isn't to use the deprecated compiler APIs 🤔 jsdelivr reports 4/5 of the most versions are for v4.0.0 and lower. Either way, it looks like this is a part of the public API (we export this createSystem fn) - can you swap this out with stencil.js and validate that works in a small Node project that calls createSystem?

[alicewriteswrongs]

@rwaskiewicz good catch, opened a docs PR here: ionic-team/stencil-site#1397

[rwaskiewicz]

@alicewriteswrongs it looks like the second part of my original feedback wasn't addressed (#5645 (review))

2. We still have a reference to this file in the compiler itself, at

   stencil/src/compiler/sys/stencil-sys.ts

   Line 146 in b3886aa

   return sys.getRemoteModuleUrl({ moduleId: '@stencil/core', path: 'compiler/stencil.min.js' });

   . I wonder if we overlooked the possibility of pulling in Stencil from a CDN in a way that isn't to use the deprecated compiler APIs 🤔 jsdelivr reports 4/5 of the most versions are for v4.0.0 and lower. Either way, it looks like this is a part of the public API (we export this createSystem fn) - can you swap this out with stencil.js and validate that works in a small Node project that calls createSystem?

[rwaskiewicz]

Bah, sorry, meant to "request changes" rather than comment just now

[alicewriteswrongs]

yeah was just looking at that, I made that change and then installed in a project locally and created a small node script to import and use the compiler API and it works fine

[tanner-reits]

LGTM once the change to src/compiler/sys/stencil-sys.ts is made

[alicewriteswrongs]

just pushed the commit that changes that lil function over