refactor(build): remove dependencies.json generation

.github/workflows/build.yml

@@ -38,4 +38,4 @@ jobs:
         with:
           name: stencil-core
           output: stencil-core-build.zip
-          paths: build cli compiler dependencies.json dev-server internal mock-doc scripts/build screenshot sys testing
+          paths: build cli compiler dev-server internal mock-doc scripts/build screenshot sys testing

.gitignore

@@ -45,7 +45,6 @@ dist/
 test/**/www/*
 test/**/hydrate/*
 .stencil
-/dependencies.json
 coverage/**
 
 # TODO(STENCIL-446): Remove these once `strictNullChecks` is enabled

.prettierignore

@@ -1,6 +1,3 @@
-# auto-generated dependencies list
-/dependencies.json
-
 # npm packages in the root of the project and subdirectories
 node_modules/
 

package.json

@@ -15,7 +15,6 @@
     "bin/",
     "cli/",
     "compiler/",
-    "dependencies.json",
     "dev-server/",
     "internal/",
     "mock-doc/",

scripts/build.ts

@@ -13,7 +13,6 @@ import { testing } from './bundles/testing';
 import { createLicense } from './license';
 import { release } from './release';
 import { validateBuild } from './test/validate-build';
-import { updateDependenciesJson } from './utils/dependencies-json';
 import { BuildOptions } from './utils/options';
 
 /**
@@ -54,7 +53,6 @@ export async function createBuild(opts: BuildOptions): Promise<readonly RollupOp
     emptyDir(opts.output.mockDocDir),
     emptyDir(opts.output.sysNodeDir),
     emptyDir(opts.output.testingDir),
-    updateDependenciesJson(opts),
   ]);
 
   await sysNodeExternalBundles(opts);

scripts/bundles/compiler.ts

@@ -9,7 +9,6 @@ import sourcemaps from 'rollup-plugin-sourcemaps';
 import { minify, MinifyOptions } from 'terser';
 
 import { getBanner } from '../utils/banner';
-import { getTypeScriptDefaultLibNames } from '../utils/dependencies-json';
 import type { BuildOptions } from '../utils/options';
 import { writePkgJson } from '../utils/write-pkg-json';
 import { aliasPlugin } from './plugins/alias-plugin';
@@ -228,3 +227,12 @@ async function minifyStencilCompiler(code: string, opts: BuildOptions) {
 
   return code;
 }
+
+/**
+ * Helper function that reads in the `lib.*.d.ts` files in the TypeScript lib/ directory on disk.
+ * @param opts the Stencil build options, which includes the location of the TypeScript lib/
+ * @returns all file names that match the `lib.*.d.ts` format
+ */
+async function getTypeScriptDefaultLibNames(opts: BuildOptions): Promise<string[]> {
+  return (await fs.readdir(opts.typescriptLibDir)).filter((f) => f.startsWith('lib.') && f.endsWith('.d.ts'));
+}

src/cli/run.ts

@@ -1,6 +1,5 @@
 import { hasError, isFunction, shouldIgnoreError } from '@utils';
 
-import { dependencies } from '../compiler/sys/dependencies.json';
 import { createLogger } from '../compiler/sys/logger/console-logger';
 import type * as d from '../declarations';
 import { ValidatedConfig } from '../declarations';
@@ -53,17 +52,6 @@ export const run = async (init: d.CliInitOptions) => {
       return sys.exit(1);
     }
 
-    const ensureDepsResults = await sys.ensureDependencies({
-      rootDir: findConfigResults.rootDir,
-      logger,
-      dependencies: dependencies as any,
-    });
-
-    if (hasError(ensureDepsResults.diagnostics)) {
-      logger.printDiagnostics(ensureDepsResults.diagnostics);
-      return sys.exit(1);
-    }
-
     const coreCompiler = await loadCoreCompiler(sys);
 
     if (task === 'version' || flags.version) {
@@ -100,8 +88,6 @@ export const run = async (init: d.CliInitOptions) => {
       sys.applyGlobalPatch(validated.config.rootDir);
     }
 
-    await sys.ensureResources({ rootDir: validated.config.rootDir, logger, dependencies: dependencies as any });
-
     await telemetryAction(sys, validated.config, coreCompiler, async () => {
       await runTask(coreCompiler, validated.config, task, sys);
     });

src/compiler/index.ts

@@ -16,7 +16,6 @@ export { loadConfig } from './config/load-config';
 export { optimizeCss } from './optimize/optimize-css';
 export { optimizeJs } from './optimize/optimize-js';
 export { createPrerenderer } from './prerender/prerender-main';
-export { dependencies } from './sys/dependencies.json';
 export { path } from './sys/modules/path';
 export { nodeRequire } from './sys/node-require';
 export { createSystem } from './sys/stencil-sys';

src/declarations/stencil-public-compiler.ts

@@ -990,11 +990,20 @@ export interface CompilerSystem {
    */
   createWorkerController?(maxConcurrentWorkers: number): WorkerMainController;
   encodeToBase64(str: string): string;
+
+  // TODO(STENCIL-727): Remove this from the sys interface
+  /**
+   * @deprecated
+   */
   ensureDependencies?(opts: {
     rootDir: string;
     logger: Logger;
     dependencies: CompilerDependency[];
   }): Promise<{ stencilPath: string; diagnostics: Diagnostic[] }>;
+  // TODO(STENCIL-727): Remove this from the sys interface
+  /**
+   * @deprecated
+   */
   ensureResources?(opts: { rootDir: string; logger: Logger; dependencies: CompilerDependency[] }): Promise<void>;
   /**
    * process.exit()

src/sys/node/node-sys.ts

@@ -199,12 +199,19 @@ export function createNodeSys(c: { process?: any } = {}): CompilerSystem {
       return Buffer.from(str).toString('base64');
     },
     async ensureDependencies() {
+      // TODO(STENCIL-727): Remove this from the sys interface
+      console.warn(`ensureDependencies will be removed in a future version of Stencil.`);
+      console.warn(`To get the stencilPath, please use getCompilerExecutingPath().`);
+
       return {
         stencilPath: sys.getCompilerExecutingPath(),
         diagnostics: [],
       };
     },
-    async ensureResources() {},
+    async ensureResources() {
+      // TODO(STENCIL-727): Remove this from the sys interface
+      console.warn(`ensureResources is a no-op, and will be removed in a future version of Stencil`);
+    },
     exit: async (exitCode) => {
       await runInterruptsCallbacks();
       exit(exitCode);