fix(compiler): fix transitive module dependencies in unit tests (#2178) #2549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve a few
Cannot use import statement outside a module
errors when spec files are run.There's a slightly deeper problem here re: who decides what is a module. Both typescript and jest can be configured to accept different extensions as module types, but neither configuration is honoured by the stencil compiler when spec files are run. Perhaps a better fix would be to inspect the
opts
in this helper function to determine which extensions to add here.Adding
js
to the list of files to compile may introduce potential slowness or problems, as more files will be run through the typescript compiler now.